fix(components): update refereces to ban icon (#3169)

salesforce-ux · Mar 22, 2018 · cd98ab6 · cd98ab6
1 parent 9bddfde
commit cd98ab6
Show file tree

Hide file tree

Showing 13 changed files with 35 additions and 36 deletions.
diff --git a/ui/components/alert/__tests__/__snapshots__/renders_a_error_alert.json b/ui/components/alert/__tests__/__snapshots__/renders_a_error_alert.json
diff --git a/ui/components/alert/__tests__/index.spec.js b/ui/components/alert/__tests__/index.spec.js
@@ -45,7 +45,7 @@ it('renders a error alert', () =>
         containerClassName="slds-m-right_x-small"
         className="slds-icon_x-small"
         assistiveText={false}
-        symbol="ban"
+        symbol="error"
       />
       <h2>
         Your browser is currently not supported. Your Salesforce may be

diff --git a/ui/components/alert/base/example.jsx b/ui/components/alert/base/example.jsx
@@ -81,7 +81,7 @@ export let states = [
           containerClassName="slds-m-right_x-small"
           className="slds-icon_x-small"
           assistiveText={false}
-          symbol="ban"
+          symbol="error"
         />
         <h2>
           Your browser is currently not supported. Your Salesforce may be

diff --git a/ui/components/alert/docs.mdx b/ui/components/alert/docs.mdx
@@ -81,7 +81,7 @@ Use the error variant when you need to alert the user about an error in the syst
         containerClassName="slds-m-right_x-small"
         className="slds-icon_x-small"
         assistiveText={false}
-        symbol="ban"
+        symbol="error"
       />
       <h2>
         Your browser is currently not supported. Your Salesforce may be

diff --git a/ui/components/data-tables/index.jsx b/ui/components/data-tables/index.jsx
@@ -573,7 +573,7 @@ export const ErrorTd = props => (
         }
       )}
       id={'error-0' + props.index}
-      symbol="ban"
+      symbol="error"
       tabIndex={props.actionableMode && props.hasError ? null : '-1'}
       title={`Item ${props.index} has errors`}
     />

diff --git a/ui/components/data-tables/inline-edit/example.jsx b/ui/components/data-tables/inline-edit/example.jsx
@@ -390,7 +390,7 @@ export let states = [
               <FeedbackHeader
                 headingId={headingUniqueId}
                 title="Resolve error"
-                symbol="ban"
+                symbol="error"
               />
             }
             style={{

diff --git a/ui/components/docked-form-footer/base/example.jsx b/ui/components/docked-form-footer/base/example.jsx
@@ -35,7 +35,7 @@ export let states = [
           assistiveText="Resolve error"
           className="slds-button_icon slds-button_icon-error"
           iconClassName="slds-button__icon_large"
-          symbol="ban"
+          symbol="error"
           title="Resolve error"
         />
         <button type="button" className="slds-button slds-button_neutral">
@@ -56,7 +56,7 @@ export let states = [
           assistiveText="Resolve error"
           className="slds-button_icon slds-button_icon-error"
           iconClassName="slds-button__icon_large"
-          symbol="ban"
+          symbol="error"
           title="Resolve error"
         />
         <button type="button" className="slds-button slds-button_neutral">
@@ -72,7 +72,7 @@ export let states = [
             <FeedbackHeader
               headingId={headingUniqueId}
               title="Resolve error"
-              symbol="ban"
+              symbol="error"
             />
           }
           closeButton

diff --git a/ui/components/file-selector/integrated/example.jsx b/ui/components/file-selector/integrated/example.jsx
@@ -37,7 +37,7 @@ let IntegratedFileSelector = props => (
           <SvgIcon
             className="slds-file-selector__body-icon slds-icon slds-icon-text-default"
             sprite="utility"
-            symbol="ban"
+            symbol="error"
           />
         ) : (
           <SvgIcon
@@ -47,11 +47,9 @@ let IntegratedFileSelector = props => (
           />
         )}
         <span className="slds-file-selector__text slds-file-selector__text_integrated slds-text-heading_medium slds-text-align_center">
-          {props.draggoverError ? (
-            'Too many files selected. Attach up to 1 file.'
-          ) : (
-            'Drop Files'
-          )}
+          {props.draggoverError
+            ? 'Too many files selected. Attach up to 1 file.'
+            : 'Drop Files'}
         </span>
       </label>
     </div>

diff --git a/ui/components/input/base/example.jsx b/ui/components/input/base/example.jsx
@@ -378,7 +378,7 @@ export let examples = [
       <FormElement className="slds-text-align_center">
         <ButtonIcon
           className="slds-button_icon-small slds-input__button_decrement"
-          symbol="error"
+          symbol="ban"
           assistiveText={'Decrement counter'}
           title={'Decrement counter'}
         />

diff --git a/ui/components/popovers/__tests__/__snapshots__/renders_an_error_popover.json b/ui/components/popovers/__tests__/__snapshots__/renders_an_error_popover.json
diff --git a/ui/components/popovers/__tests__/__snapshots__/renders_an_error_popover_with_footer.json b/ui/components/popovers/__tests__/__snapshots__/renders_an_error_popover_with_footer.json
diff --git a/ui/components/popovers/__tests__/snapshot.spec.js b/ui/components/popovers/__tests__/snapshot.spec.js
@@ -110,7 +110,7 @@ it('renders an error popover', () =>
       className="slds-popover_error slds-nubbin_bottom-left"
       headingId={headingUniqueId}
       header={
-        <FeedbackHeader title="Resolve the following errors" symbol="ban" />
+        <FeedbackHeader title="Resolve the following errors" symbol="error" />
       }
       closeButton
       inverse
@@ -131,7 +131,7 @@ it('renders an error popover with footer', () =>
       className="slds-popover_error slds-nubbin_bottom-left"
       headingId={headingUniqueId}
       header={
-        <FeedbackHeader title="Resolve the following errors" symbol="ban" />
+        <FeedbackHeader title="Resolve the following errors" symbol="error" />
       }
       footer={<FeedbackFooter />}
       closeButton

diff --git a/ui/components/popovers/error/example.jsx b/ui/components/popovers/error/example.jsx
@@ -4,6 +4,7 @@
 import React from 'react';
 import SvgIcon from '../../../shared/svg-icon';
 import ButtonIcon from '../../button-icons/';
+import { UtilityIcon } from '../../icons/base/example';
 import { Popover } from '../base/example';
 import classNames from 'classnames';
 import _ from '../../../shared/helpers';
@@ -15,17 +16,14 @@ export const FeedbackHeader = props => (
     <div className="slds-media slds-media_center slds-has-flexi-truncate ">
       {props.symbol ? (
         <div className="slds-media__figure">
-          <span
-            className={'slds-icon_container slds-icon-utility-' + props.symbol}
-          >
-            <SvgIcon
-              className={classNames('slds-icon slds-icon_x-small', {
-                'slds-icon-text-default': props.iconDefault
-              })}
-              sprite="utility"
-              symbol={props.symbol}
-            />
-          </span>
+          <UtilityIcon
+            className={classNames('slds-icon_x-small', {
+              'slds-icon-text-default': props.iconDefault
+            })}
+            symbol={props.symbol}
+            title={false}
+            assistiveText={false}
+          />
         </div>
       ) : null}
       <div className="slds-media__body">
@@ -59,7 +57,7 @@ export default (
       <FeedbackHeader
         headingId={headingUniqueId}
         title="Resolve error"
-        symbol="ban"
+        symbol="error"
       />
     }
     closeButton
@@ -87,7 +85,7 @@ export let examples = [
           <FeedbackHeader
             headingId={headingUniqueId}
             title="Resolve error"
-            symbol="ban"
+            symbol="error"
           />
         }
         footer={<FeedbackFooter />}