Fix SFTP connection remaining problem #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakama
force-pushed
the
fix-connection-remaining
branch
3 times, most recently
from
8e25dbf
to
3ff236e
Compare
sakama
force-pushed
the
fix-connection-remaining
branch
from
3ff236e
to
dc5f3f2
Compare
sakama
changed the title
|
CI failure should be another problem. |
|
hmm CI passed successfully. It seems very unstable, though. |
muga
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this plugin doesn't close SFTP connection after embulk(run|guess|preview).
This problem seems only happens with EmbulkEmbed.
Generally, JVM will finish its process after embulk(run|guess|preview) and SFTP connection will be closed so that this problem doesn't happens for non EmbulkEmbed users.