Fix last_path generation logic #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakama
force-pushed
the
fix-last-path-generation-logic
branch
4 times, most recently
from
035528c
to
37f40cc
Compare
| control.run(taskSource, taskCount); | ||
|
|
||
| ConfigDiff configDiff = Exec.newConfigDiff(); | ||
| if (task.getIncremental()) { | ||
| configDiff.set("last_path", SftpFileInput.getRelativePath(task.getFiles().getLastPath(task.getLastPath()))); | ||
| configDiff.set("last_path", lastPath); |
There was a problem hiding this comment.
When getRelativePath returns null, the plugin should not return {"last_path": null}. It should return empty config_diff.
if (task.getIncremental() && lastPath != null) {
configDiff.set("last_path", lastPath);
}
?
sakama
force-pushed
the
fix-last-path-generation-logic
branch
from
37f40cc
to
eb03570
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that current implementation fails to generate
last_pathwith following condition.