Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make networkx compatibel with numpy-1.4.1 #9854

Closed
sagetrac-maldun mannequin opened this issue Sep 4, 2010 · 11 comments
Closed

make networkx compatibel with numpy-1.4.1 #9854

sagetrac-maldun mannequin opened this issue Sep 4, 2010 · 11 comments

Comments

@sagetrac-maldun
Copy link
Mannequin

sagetrac-maldun mannequin commented Sep 4, 2010

In order to finish Ticket #9808 there have to be a small patch applied to networkx.

A small change has to be done in convert.py, namely

numpy.core.defmatrix

changes to

numpy.matrixlib.defmatrix

(see the diff for details)

Component: packages: standard

Author: Stefan Reiterer

Issue created by migration from https://trac.sagemath.org/ticket/9854

@sagetrac-maldun

This comment has been minimized.

@sagetrac-maldun
Copy link
Mannequin Author

sagetrac-maldun mannequin commented Sep 4, 2010

Attachment: convert.py.diff.gz

changes

@sagetrac-maldun

This comment has been minimized.

@sagetrac-maldun
Copy link
Mannequin Author

sagetrac-maldun mannequin commented Sep 4, 2010

Attachment: convert.py.2.diff.gz

Downward compatibel patch

@sagetrac-maldun
Copy link
Mannequin Author

sagetrac-maldun mannequin commented Sep 4, 2010

modified version for networkx to make numpy-1.4.1 compatible

@sagetrac-maldun
Copy link
Mannequin Author

sagetrac-maldun mannequin commented Sep 4, 2010

comment:4

Attachment: networkx-1.0.1.p0.spkg.gz

@sagetrac-maldun

This comment has been minimized.

@kiwifb
Copy link
Member

kiwifb commented Sep 4, 2010

comment:5

As I mentioned in the numpy upgrade bug we are moving to networkx-1.2.
So this bug may be invalid. Check have to be done against networkx-1.2 not 1.0.1.

@sagetrac-maldun
Copy link
Mannequin Author

sagetrac-maldun mannequin commented Sep 4, 2010

comment:6

Ok like mentioned in #9808 networkx-1.2 works with the numpy packages just fine.
But I had to install a new version, because I was not able to just install networkx-1.2 into my old version of sage-4.2. After intalling it and applying the patches it still didn't work correctly. But the patch of 1.0.1 above worked well for me. So it could still be usefull.
But I think we could close this ticket then.

@sagetrac-maldun sagetrac-maldun mannequin removed the s: needs review label Sep 4, 2010
@sagetrac-maldun sagetrac-maldun mannequin closed this as completed Sep 4, 2010
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 5, 2010

comment:8

How is this ticket considered fixed? Do you want the attached NetworkX package to be merged in the Sage standard repository? If so, has it been merged yet? If not, you need to explain why you closed this ticket.

@sagetrac-mvngu sagetrac-mvngu mannequin added this to the sage-4.5.3 milestone Sep 5, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin added the s: needs work label Sep 5, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin reopened this Sep 5, 2010
@kiwifb
Copy link
Member

kiwifb commented Sep 5, 2010

comment:9

Replying to @sagetrac-mvngu:

How is this ticket considered fixed? Do you want the attached NetworkX package to be merged in the Sage standard repository? If so, has it been merged yet? If not, you need to explain why you closed this ticket.

It should have been closed invalid. Numpy-1.4.1 and networkx-1.0.1 don't go along
very well together. But it doesn't matter since next sage release will use networkx-1.2 which works well with numpy-1.4.1. I am changing it to "invalid".

@kiwifb kiwifb closed this as completed Sep 5, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin removed this from the sage-4.5.3 milestone Sep 6, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant