Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes in tableaux latex output #4362

Closed
dwbump mannequin opened this issue Oct 24, 2008 · 6 comments
Closed

Bug fixes in tableaux latex output #4362

dwbump mannequin opened this issue Oct 24, 2008 · 6 comments

Comments

@dwbump
Copy link
Mannequin

dwbump mannequin commented Oct 24, 2008

The latex output of tableaux is a broke, which affects the latex output in CrystalOfTableaux. Patches that fix this were attached to #4355 but I should have created a new ticket for these since that ticket really proposes something different.

See #4355 for the patches.

See http://groups.google.com/group/sage-combinat-devel/browse_thread/thread/3fff0cbc6b44b483?hl=en for discussion. But in a nutshell try

latex(Tableau([[1,2,3],[2,2],[3,4],[4]])) 
latex(Tableau([[1,1,2,3,4],[2,2,2],[3]])) 
latex(Tableau([[1],[2],[3],[4]])) 
latex(Tableau([[1,2,3,4]])) 
latex(Tableau([[1,2,3,4],[5,6,7,8]])) 
latex(Tableau([[1,2,3,4],[5,6,7,8],[9]])) 
latex(Tableau([[1,2,],[5,6],[7,9]])) 
latex(Tableau([[1,2,],[5,6],[7,9],[9]])) 
latex(Tableau([[1,2,3,4,5,],[6]])) 
latex(Tableau([[1,2,3,4,5,],[6],[7],[8],[9]])) 

etc or

CrystalOfTableaux("A2",shape=[3,1]).latex_file("/home/bump/tmp/test.tex")

to see the defect.

CC: @sagetrac-sage-combinat

Component: combinatorics

Issue created by migration from https://trac.sagemath.org/ticket/4362

@dwbump dwbump mannequin added c: combinatorics labels Oct 24, 2008
@dwbump dwbump mannequin assigned mwhansen Oct 24, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Oct 24, 2008

Attachment: tableaux_output.patch.gz

First of Dan's patches from #4355

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Oct 24, 2008

Attachment: tableaux_output1.patch.gz

Second of Dan's patches from #4355

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Oct 24, 2008

comment:1

Dan,

I have moved the patches from #4355 over here and will delete them on the other ticket. Having patches from another ticket applied via this ticket will only make things more complicated than they need to be.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title Bug fixes in tableaux latex output [with patches at #4355. Needs review.] Bug fixes in tableaux latex output [with patche, needs review] Oct 24, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-3.2 milestone Oct 24, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title Bug fixes in tableaux latex output [with patche, needs review] Bug fixes in tableaux latex output Oct 25, 2008
@mwhansen
Copy link
Contributor

mwhansen commented Nov 6, 2008

comment:3

I tested this out on all the examples, and it looks good to me.

@dwbump
Copy link
Mannequin Author

dwbump mannequin commented Nov 6, 2008

comment:4

Attachment: tableaux_output2.patch.gz

Nicolas suggested that the tests should reflect the problem. As it turns out the existing tests all have square tableaux (in tensor_product.py, tableau.py and output.py) which is a rare case that is not broke for the original code.

http://groups.google.com/group/sage-combinat-devel/msg/cd0de81b0e2f0ae5?hl=en

Nicolas posted this before Mike reviewed the patch. In view of Nicolas' comment I'm uploading
a third patch tableaux_output2.patch that makes the tests non-rectangular tableaux
for which the original code was broke.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Nov 7, 2008

comment:5

Merged all three patches in Sage 3.2.rc0.

Dan: Please make sure that you post patches and not diffs. I did apply and commit the patches above in your name, so no need to update anything here.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Nov 7, 2008
@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-3.2.1, sage-3.2 Nov 7, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant