Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove one trace of python2 #34649

Closed
fchapoton opened this issue Oct 11, 2022 · 8 comments
Closed

remove one trace of python2 #34649

fchapoton opened this issue Oct 11, 2022 · 8 comments
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

in one build script

Component: build

Author: Frédéric Chapoton

Branch/Commit: 86f8a14

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34649
@fchapoton fchapoton added this to the sage-9.8 milestone Oct 11, 2022
@fchapoton
Copy link
Contributor Author

Commit: 86f8a14

@fchapoton
Copy link
Contributor Author

New commits:

86f8a14remove one trace of python2

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34649

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 12, 2022

comment:2

sage_bootstrap still needs to support Python 2 - see https://doc.sagemath.org/html/en/installation/source.html#command-line-tools

@mkoeppe mkoeppe removed this from the sage-9.8 milestone Oct 12, 2022
@fchapoton
Copy link
Contributor Author

comment:3

this does not break py2 compatibility

@fchapoton fchapoton added this to the sage-9.8 milestone Oct 12, 2022
@fchapoton fchapoton removed the pending label Oct 12, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 13, 2022

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 13, 2022

comment:4

Right

@vbraun
Copy link
Member

vbraun commented Oct 17, 2022

Changed branch from u/chapoton/34649 to 86f8a14

@vbraun vbraun closed this as completed in 66ad265 Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @mkoeppe