-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix random doctest failure in EllipticCurveHom_velusqrt #34467
Milestone
Comments
comment:2
How about adding a doctest for this problematic case with an explanation and a link to this ticket? |
comment:4
Done. |
comment:5
Thanks. LGTM. |
Reviewer: Kwankyu Lee |
Changed branch from public/increase_velusqrt_minimum_degree_to_9 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As reported in #34303 comment:25,
EllipticCurveHom_velusqrt
accidentally computes an irrational isogeny for curves defined overGF(3)
with7
rational points. The reason is that the computation internally requires a point lying outside the kernel, which only in this one specific case will be defined over a cubic instead of a quadratic extension. This in turn implies the linear factors in the numerator of the isogeny won't match up in conjugate pairs, causing the problem.Quick fix: Simply restrict the implementation to degrees
≥ 9
. Since the olderEllipticCurveIsogeny
implementation is much faster for degrees this small anyway, this restriction won't be a problem for any remotely realistic code.CC: @antonio-rojas
Component: elliptic curves
Author: Lorenz Panny
Branch/Commit:
467eda5
Reviewer: Kwankyu Lee
Issue created by migration from https://trac.sagemath.org/ticket/34467
The text was updated successfully, but these errors were encountered: