Method to get cells in horizontal/vertical border strip

[trevorkarn]

The methods Partition.add_*_border_strip where * is horizontal or vertical return new partitions. This ticket proposes a method that returns the indices of the cells of these new partitions which are not in the original partition.

Depends on #34339

CC: @tscrim @trevorkarn

Component: combinatorics

Keywords: gsoc2022 partition cell border-strip

Author: Trevor K. Karn

Branch/Commit: 218b548

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34345

[trevorkarn]

Branch: u/tkarn/strip-cells-34345

[trevorkarn]

New commits:

6ccd9e4	Optimization of add_*_border_strip() and doctest update.
69d1ea8	Add horizontal cells

[trevorkarn]

Commit: 69d1ea8

[trevorkarn]

Dependencies: #34339

[sagetrac-git]

Changed commit from 69d1ea8 to 3d7a37b

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3d7a37b

Add vertical strips

[tscrim]

comment:5

For these methods, since we are adding them, it would be better if they were generators that iterated through the different strips. (I wanted to do this for the other methods, but I didn't want to deal with the backwards incompatibility.) So instead of res.append(foo), it would be yield foo.

Why the change in order (horizontal then vertical)? It would be better to be consistent.

In the vertical strip, you can move the creation of tmp outside of the for loop.

[sagetrac-git]

Changed commit from 3d7a37b to 218b548

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

218b548

Make a generator, reorder, and move tmp variable

[trevorkarn]

comment:7

Should be fixed.

[tscrim]

comment:8

Thanks. LGTM.

[tscrim]

Reviewer: Travis Scrimshaw

[vbraun]

Changed branch from u/tkarn/strip-cells-34345 to 218b548