-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setuptools 63.4.3, setuptools_wheel 65.x, tomlkit 0.11.4, importlib_resources 5.9.0, importlib_metadata 4.12.0, distlib 0.3.6, hatchling 1.10.0, pathspec 0.10.1 #34344
Comments
Commit: |
This comment has been minimized.
This comment has been minimized.
comment:3
This version of setuptools breaks the build of our numpy-1.22.4 package
|
Dependencies: #34110 |
comment:5
Actually it needs to be |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
The updated |
Work Issues: Revert #34442 |
comment:12
The upgrade to numpy 1.23.3 (#34110) does not help. In fact, upstream numpy is moving away from Breaking the numpy build system has been raised as pypa/setuptools#3549 - no solution as of 2022-09-23 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Changed work issues from Revert #34442's install-requires (but keep pin in conda.txt) to none |
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:23
This almost looks like a straightforward upgrade. My only questions are about |
comment:24
Since #33789, we use build isolation for all Python packages that use |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:26
Okay, let's merge it. |
Reviewer: John Palmieri |
comment:27
Thanks! |
Changed branch from u/mkoeppe/update_setuptools_to_64_0_0 to |
Numpy's distutils-based build system needs setuptools < 64. We upgrade to the latest suitable version, 63.4.3, which will be used in non-PEP-517 builds. https://setuptools.pypa.io/en/latest/history.html#v63-4-3
For PEP 517 builds, we provide the latest setuptools (65.x) as a wheel, which will be used in the isolated build environments of PEP 517 packages. https://setuptools.pypa.io/en/latest/history.html#v65-3-0
The update to 65.3 brings PEP 660 editable installs.
Here on this ticket, we disable them. The follow-up ticket #34209 will switch editable builds to this new technology.
We also update a few more build system related packages.
Depends on #34442
CC: @kiwifb @antonio-rojas @saraedum @jhpalmieri
Component: packages: standard
Author: Matthias Koeppe
Branch/Commit:
664e98c
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/34344
The text was updated successfully, but these errors were encountered: