Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix p_group_cohomology doctest errors #34333

Open
mkoeppe opened this issue Aug 10, 2022 · 4 comments
Open

Fix p_group_cohomology doctest errors #34333

mkoeppe opened this issue Aug 10, 2022 · 4 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 10, 2022

(from #30787)

Depends on #30787

CC: @simon-king-jena @dimpase @jhpalmieri @tscrim

Component: packages: optional

Issue created by migration from https://trac.sagemath.org/ticket/34333

@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 10, 2022
@jhpalmieri
Copy link
Member

comment:1

I have attached the failures that I see.

@jhpalmieri
Copy link
Member

Attachment: p_grp_cohom_tests.log

@tscrim
Copy link
Collaborator

tscrim commented Aug 11, 2022

comment:2

There is also the one within the Sage library:

sage -t --warn-long 62.5 --random-seed=230138939486715312795148381621394057005 src/sage/tests/modular_group_cohomology.py
**********************************************************************
File "src/sage/tests/modular_group_cohomology.py", line 55, in sage.tests.modular_group_cohomology
Failed example:
    ascii_art(H.bar_code('LowerCentralSeries')[2])# optional - p_group_cohomology
Expected:
        *
      *-*
      *-*
    *
Got:
      *-*
      *-*
      *-*
      *-*
    *
**********************************************************************
1 item had failures:
   1 of  18 in sage.tests.modular_group_cohomology
    [17 tests, 1 failure, 3.71 s]

@jhpalmieri
Copy link
Member

comment:3

I don't know the math well enough to be able to do the computations myself, but I hope that Simon (or his coauthor) can check the calculations arising in

sage: from pGroupCohomology import CohomologyRing
sage: H = CohomologyRing(27,4)
sage: H.make()
sage: BC = H.bar_code('LowerCentralSeries')
sage: BC.show()
...
sage: BC.data()
...

and in particular the ascii_art error here.

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants