Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to --warn-long test flag #32995

Open
orlitzky opened this issue Dec 8, 2021 · 2 comments
Open

improvements to --warn-long test flag #32995

orlitzky opened this issue Dec 8, 2021 · 2 comments

Comments

@orlitzky
Copy link
Contributor

orlitzky commented Dec 8, 2021

As a follow-up to #32973 and #32981, there are a few other ways we could improve the --warn-long flag to keep our test suite speedy:

  1. Add a flag like -Werror to the test runner, so that warnings are turned into errors that are reflected in the exit code. This will allow the CI to catch them. Another idea would be to have an --error-long flag that triggers errors instead of warnings at an ostensibly higher limit.
  2. Summarize the --warn-long warnings at the end of the test run, so that they're all visible to the user without having to dig through a log file.
  3. Add a separate option for warning about # long time tests. Currently when running with --long, you have to use a very long warning time, which then essentially hides the warnings for non-long tests that take too long.

CC: @tornaria

Component: doctest framework

Issue created by migration from https://trac.sagemath.org/ticket/32995

@orlitzky orlitzky added this to the sage-9.5 milestone Dec 8, 2021
@orlitzky

This comment has been minimized.

@orlitzky

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant