Features for interpreter interfaces

[mkoeppe]

Follow-up from #32649

CC: @kwankyu @seblabbe

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 944bb74

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/32866

[mkoeppe]

Branch: u/mkoeppe/features_for_interpreter_interfaces

[mkoeppe]

New commits:

eaec400

src/sage/features/interfaces.py: New

[mkoeppe]

Author: Matthias Koeppe, ...

[mkoeppe]

Commit: eaec400

[sagetrac-git]

Changed commit from eaec400 to 52ac51e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

827ca03	src/sage/features/interfaces.py: Fix and doctest exception handling
52ac51e	src/sage/features/interfaces.py (all_features): New

[sagetrac-git]

Changed commit from 52ac51e to 8081f29

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7754fae	src/sage/features/interfaces.py: Fix and doctest exception handling (fixup)
8081f29	src/sage/doctest/external.py: Use sage.features.interfaces

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

945132b

src/sage/features/interfaces.py: Fix up

[sagetrac-git]

Changed commit from 8081f29 to 945132b

[mkoeppe]

Changed author from Matthias Koeppe, ... to Matthias Koeppe

[sagetrac-git]

Changed commit from 945132b to 944bb74

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

944bb74

src/sage/features/interfaces.py: Add doctests

[seblabbe]

comment:8

Looks good to me. Doctests pass. Patchbot is green. The coverage is not 100% because of few docstring missing in staticmethods __classcall__ but these are doctested in the doc of the the class just above. So, LGTM. I tested the functionnality. In particular, I get:

sage: from sage.features.interfaces import all_features
sage: [(f,f.is_present()) for f in all_features()]
[(Feature('magma'), FeatureTestResult('magma', False)),
 (Feature('matlab'), FeatureTestResult('matlab', False)),
 (Feature('mathematica'), FeatureTestResult('mathematica', False)),
 (Feature('maple'), FeatureTestResult('maple', False)),
 (Feature('macaulay2'), FeatureTestResult('macaulay2', False)),
 (Feature('octave'), FeatureTestResult('octave', True)),
 (Feature('scilab'), FeatureTestResult('scilab', False))]

which is sometimes True and sometimes False. Therefore, the routine works.

[seblabbe]

Reviewer: Sébastien Labbé

[mkoeppe]

comment:9

Thank you!

[vbraun]

Changed branch from u/mkoeppe/features_for_interpreter_interfaces to 944bb74