Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random doctest failure in rings/polynomial/polynomial_element_generic.py #32816

Closed
yyyyx4 opened this issue Nov 3, 2021 · 8 comments
Closed

Comments

@yyyyx4
Copy link
Member

yyyyx4 commented Nov 3, 2021

Part of #32544:

sage -t --long --random-seed=43805222569518434108329399959452339425 src/sage/rings/polynomial/polynomial_element_generic.py
**********************************************************************
File "src/sage/rings/polynomial/polynomial_element_generic.py", line 783, in sage.rings.polynomial.polynomial_element_generic.Polynomial_generic_sparse.quo_rem
Failed example:
    f.quo_rem(g)
Expected:
    Traceback (most recent call last):
    ...
    ArithmeticError: Division non exact (consider coercing to polynomials over the fraction field)
Got:
    (-y^5 + 2*y^2, y^3 - 2*x^2*y^2 - y)
**********************************************************************

(From a patchbot run in #32380.)

CC: @tscrim

Component: algebra

Author: Jonathan Kliem

Branch/Commit: 0f7cca7

Reviewer: Markus Wageringel

Issue created by migration from https://trac.sagemath.org/ticket/32816

@yyyyx4 yyyyx4 added this to the sage-9.5 milestone Nov 3, 2021
@kliem
Copy link
Contributor

kliem commented Nov 3, 2021

comment:1

Took a while to understand what the doctest is about.

Thing is, Euclidean algorithm may still work, if the leading coefficient is not a unit, e.g.
25*x^2 + 5*x is divisible by 5*x. Its a bit like claiming, that integers cannot be divided...


New commits:

0f7cca7euclidean division may still work, if the leading coefficient is not a unit

@kliem
Copy link
Contributor

kliem commented Nov 3, 2021

Author: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Nov 3, 2021

Branch: public/32816

@kliem
Copy link
Contributor

kliem commented Nov 3, 2021

Commit: 0f7cca7

@mwageringel
Copy link

comment:2

LGTM.

@mwageringel
Copy link

Reviewer: Markus Wageringel

@kliem
Copy link
Contributor

kliem commented Nov 5, 2021

comment:3

Thank you.

@vbraun
Copy link
Member

vbraun commented Nov 15, 2021

Changed branch from public/32816 to 0f7cca7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants