Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make groups doctests ready for random seeds #32107

Closed
kliem opened this issue Jul 3, 2021 · 11 comments
Closed

Make groups doctests ready for random seeds #32107

kliem opened this issue Jul 3, 2021 · 11 comments
Labels
c: doctest framework c: group theory p: major / 3 t: enhancement t: tests
Milestone
sage-9.4

Comments

@kliem
Copy link
Contributor

kliem commented Jul 3, 2021

This ticket makes

sage -t --long --random-seed=n src/sage/groups/

pass for different values n than just 0.

Component: doctest framework

Keywords: fuzzing

Author: Jonathan Kliem

Branch/Commit: 89fd4b2

Reviewer: Markus Wageringel

Issue created by migration from https://trac.sagemath.org/ticket/32107
@kliem kliem added this to the sage-9.4 milestone Jul 3, 2021
@kliem
Copy link
Contributor Author

kliem commented Jul 3, 2021

Commit: 960ce8b

@kliem
Copy link
Contributor Author

kliem commented Jul 3, 2021

Branch: public/32107

@kliem
Copy link
Contributor Author

kliem commented Jul 3, 2021

New commits:

960ce8bmake groups ready for random seeds

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

5592c58make some_elements of affine group ready for random seeds

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2021

Changed commit from 960ce8b to 5592c58

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

89fd4b2one more missing test from groups

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2021

Changed commit from 5592c58 to 89fd4b2

@mwageringel
Copy link

comment:5

LGTM.

@mwageringel
Copy link

Reviewer: Markus Wageringel

@kliem
Copy link
Contributor Author

kliem commented Jul 8, 2021

comment:6

Thank you.

@vbraun
Copy link
Member

vbraun commented Jul 23, 2021

Changed branch from public/32107 to 89fd4b2

@vbraun vbraun closed this as completed in 36277c6 Jul 23, 2021
@dimpase dimpase mentioned this issue Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: doctest framework c: group theory p: major / 3 t: enhancement t: tests
Projects
None yet
Milestone
sage-9.4
Development

No branches or pull requests
3 participants
@vbraun @kliem @mwageringel