Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Paths within $SAGE_LOCAL ($prefix) for sage_conf #31593

Closed
mkoeppe opened this issue Apr 1, 2021 · 17 comments
Closed

configure: Paths within $SAGE_LOCAL ($prefix) for sage_conf #31593

mkoeppe opened this issue Apr 1, 2021 · 17 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 1, 2021

A solution for an issue encountered in #29617

CC: @orlitzky

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: 2078fa6

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/31593

@mkoeppe mkoeppe added this to the sage-9.3 milestone Apr 1, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 1, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 1, 2021

Commit: 5161d65

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 1, 2021

comment:2

Here's a basic solution (without a new macro) that is perhaps already good enough for the moment.

It is modeled after autotools' treatment of paths derived from ${prefix} such as @exec_prefix@.

In ecl/spkg-configure.m4 you would put the quoted value '${prefix}'/lib/ecl/maxima.fas as MAXIMA_FAS.


New commits:

5161d65build/pkgs/sage_conf/src/sage_conf.py.in: Move SAGE_ROOT, SAGE_LOCAL to beginning of file; only use substitution @prefix@ once

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 1, 2021

comment:3

... which would be processed in sage_conf.py.in in the same way as I have changed ECL_CONFIG.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

986ca18build/pkgs/sage_conf/src/sage_conf.py.in: replace subst by replace

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2021

Changed commit from 5161d65 to 986ca18

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 1, 2021

Author: Matthias Koeppe

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Apr 2, 2021
@orlitzky
Copy link
Contributor

orlitzky commented Apr 2, 2021

comment:7

I've rebased #29617 onto this to see how it goes, but the idea looks good. Thanks!

@orlitzky
Copy link
Contributor

orlitzky commented Apr 2, 2021

Reviewer: Michael Orlitzky

@orlitzky
Copy link
Contributor

orlitzky commented Apr 2, 2021

comment:8

I'm optimistic, thanks again.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 3, 2021

comment:9

Thanks for the review!

@vbraun
Copy link
Member

vbraun commented May 26, 2021

comment:10

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

2078fa6Merge tag '9.4.beta0' into t/31593/configure__paths_within__sage_local___prefix__for_sage_conf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2021

Changed commit from 986ca18 to 2078fa6

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 26, 2021

comment:12

easy merge, back to positive

@vbraun
Copy link
Member

vbraun commented Jun 19, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants