sage.features.Executable: Prepend $SAGE_VENV/bin:$SAGE_LOCAL/bin to PATH

[mkoeppe]

Follow-up from #22731.

This is so that Sage becomes fully functional even when not being run from within sage-env (which sets PATH)

Of course, PATH is not actually manipulated, only Executable finds the executable in more places.

As an illustration, we update sage.interfaces.four_ti_2 and sage.interfaces.latte to use Executable.absolute_filename() from #31292. Then, after sage -i 4ti2 latte_int, the following works with this ticket:

$ venv/bin/python3 -c 'import sage.all; from sage.interfaces.four_ti_2 import four_ti_2; print(four_ti_2.groebner(lat=[[1,2,3],[1,1,1]]))'
$ venv/bin/python3 -c 'from sage.all import *; print(Polyhedron([[-3, 0], [0, 9]]).volume(measure="induced_rational"))'
3

In follow-up tickets, other code that calls executables needs to be updated to use Executable.absolute_path() from #31292. The first tickets to do so are #33440, #33465, #33466, #32645, #33467, #33405.

This is work towards:

• Meta-ticket: Set environment for subprocesses invoked by Sage #30818 Meta-ticket: Set environment for subprocesses invoked by Sage
• Meta-ticket: Replace imports from deprecated distutils #31295 Meta-ticket: Replace imports from deprecated distutils

Depends on #31292

CC: @tobiasdiez @kiwifb @tobihan @antonio-rojas @orlitzky

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: 160e9af

Reviewer: Dima Pasechnik, Tobias Diez

Issue created by migration from https://trac.sagemath.org/ticket/31296

[mkoeppe]

comment:2

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

[mkoeppe]

Dependencies: #32565

[mkoeppe]

Changed dependencies from #32565 to none

[mkoeppe]

Dependencies: #31292

[mkoeppe]

Branch: u/mkoeppe/sage_features_executable_SAGE_LOCAL

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

32ce831	sage.features.Executable.absolute_path: New
88860d3	sage.features.Executable.absolute_path: If SAGE_LOCAL != SAGE_VENV, search first in SAGE_VENV/bin, SAGE_LOCAL/bin, then PATH

[mkoeppe]

Commit: 88860d3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

8801359

src/sage/features/__init__.py: Fix import

[sagetrac-git]

Changed commit from 88860d3 to 8801359

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

403bcc1

sage.features.Executable: Fix up

[sagetrac-git]

Changed commit from 8801359 to 403bcc1

[sagetrac-git]

Changed commit from 403bcc1 to 9fad95e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

8bb7e3a	src/sage/features/__init__.py: Relax doctest
9fad95e	Merge #31292

[tobiasdiez]

comment:14

Please extract

            sage_venv = Path(SAGE_VENV)
            sage_local = Path(SAGE_LOCAL)

to a central place (I would say sage.env but you probably don't like this) for easier reuse in similar situations.

PATH = ':'.join(str(p) for p in [sage_venv / 'bin', sage_local / 'bin'])

this is a normal variable and thus should be lowercase.

[mkoeppe]

comment:24

Replying to @tobiasdiez:

sage.features.FileFeature: Replace method absolute_path by absolute_filename, with deprecation

So the plan of this is to deprecate absolute_path, then when everyone uses absolute_filename, change absolute_path to return path and then deprecate absolute_filename? Doesn't this procedure take very long?

Yes, a year, what's the rush?

[mkoeppe]

comment:25

Replying to @tobiasdiez:

What about adding an optional as_path = false argument (with deprecation if its false).

Writing that is no easier than wrapping Path(...) around the result -- and the result is not type-stable

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a4d0ed6

sage.interfaces.four_ti_2: Use Executable.absolute_filename

[sagetrac-git]

Changed commit from 9266709 to a4d0ed6

[sagetrac-git]

Changed commit from a4d0ed6 to 4252ea3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4252ea3

sage.sandpiles.sandpile: Use Executable.absolute_filename() when interfacing 4ti2

[sagetrac-git]

Changed commit from 4252ea3 to 17b9fde

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

17b9fde

sage.interfaces.latte: Use Executable.absolute_filename

[dimpase]

comment:36

I presume the latte doctest patch #33467 comment:4
should come here.

[mkoeppe]

comment:37

Yes, that's right, can you push it to the ticket please?

[dimpase]

comment:38

later today, will do.

[dimpase]

Changed commit from 17b9fde to d1cf739

[dimpase]

New commits:

d1cf739

correct latte doctests where calling with abs. names happens

[dimpase]

Changed branch from u/mkoeppe/sage_features_executable_SAGE_LOCAL to u/dimpase/sage_features_executable_SAGE_LOCAL

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

160e9af

fix doctest for more invocation of count

[sagetrac-git]

Changed commit from d1cf739 to 160e9af

[dimpase]

Reviewer: Dima Pasechnik, Tobias Diez

[mkoeppe]

comment:42

Thank you!

[vbraun]

Changed branch from u/dimpase/sage_features_executable_SAGE_LOCAL to 160e9af