Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/update the system package information for the "_recommended" dummy package #30930

Closed
mkoeppe opened this issue Nov 17, 2020 · 37 comments
Closed

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 17, 2020

Follow-up from #29557 (Add script package _recommended and generate "recommended system packages" info).

From egourgoulhon #30624 and similar reports by gh-tobiasdiez, jhpalmieri #29557:

configure ends with the following recommendations:

  configure: hint: installing the following system packages is recommended and may 
avoid building some of the above SPKGs from source:
configure:   $ sudo apt-get update 
  $ sudo apt-get install texlive-generic-extra texlive-xetex latexmk pandoc dvipng 
default-jdk ffmpeg libavdevice-dev libcdd-dev libcdd-tools libec-dev eclib-tools 
libgc-dev libgiac-dev xcas pari-gp2c lcalc liblfunction-dev libnauty-dev nauty 
pari-gp2c libpari-dev pari-doc pari-elldata pari-galdata pari-galpol pari-seadata 
sympow

The message is printed regardless of whether ffmpeg et al. are installed because build/pkgs/_recommended/spkg-configure.m4 does not check anything.

To this end, tests need to be added for the presence of the various recommended packages in the system.

We do this by splitting out individual script packages, similar to the existing build/pkgs/pandoc and build/pkgs/graphviz.

Depends on #30910
Depends on #31042

CC: @jhpalmieri @egourgoulhon @tobiasdiez @seblabbe @slel

Component: build: configure

Keywords: sd111

Issue created by migration from https://trac.sagemath.org/ticket/30930

@mkoeppe mkoeppe added this to the sage-9.3 milestone Nov 17, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

comment:3

The debian package providing latex is updated in #30910, which I have made a dependency.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

Dependencies: #30910

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

Commit: afdd20f

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

comment:5

This is taking care of the issue with pandoc.


Last 10 new commits:

050dcb8tox.ini (local-sudo): Use --yes --no-install-recommends
c8fbe0btox.ini (local-sudo): Ignore errors when IGNORE_MISSING_SYSTEM_PACKAGES=yes
ff34897tox.ini (local): Guess the package system if it is not provided as a factor
e27ff19Merge branch 'u/mkoeppe/tox_ini__add_environments_local_sudo_ubuntu_standard__etc_' of git://trac.sagemath.org/sage into public/build/fixwsl
6ff45c4Cleanup workflow
5348144Replace texlive-generic-extra
0fd029fNarrow down events that trigger the workflow
3ccae02build/pkgs/_recommended/distros/debian.txt: Update latex package
6d0e673Merge branch 't/30910/public/build/fixwsl' into t/30930/add_update_the_system_package_information_for_the___recommended__dummy_package
afdd20fbuild/pkgs/_recommended/distros, src/doc/bootstrap: Remove duplication of pandoc

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

comment:6

That configure keeps suggesting packages from the _recommended dummy package is because build/pkgs/_recommended/spkg-configure.m4 does not check anything.

To improve this, tests need to be added for the presence of the various recommended packages in the system. Either in build/pkgs/_recommended/spkg-configure.m4 or in individual "script packages" similar to build/pkgs/pandoc.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

Author: Matthias Koeppe

@dimpase
Copy link
Member

dimpase commented Nov 18, 2020

comment:8

OK, this does the trick for pandoc. I guess ffmpeg, imagemagick, texinfo need semi-dummy packages created (i.e. with spkg-configure checking their presence, but without real spkg-install), right?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 18, 2020

comment:9

Replying to @dimpase:

OK, this does the trick for pandoc. I guess ffmpeg, imagemagick, texinfo need semi-dummy packages created (i.e. with spkg-configure checking their presence, but without real spkg-install), right?

That's right. Likewise for libxml in #30899.

@dimpase
Copy link
Member

dimpase commented Nov 18, 2020

comment:10

Replying to @mkoeppe:

Replying to @dimpase:

OK, this does the trick for pandoc. I guess ffmpeg, imagemagick, texinfo need semi-dummy packages created (i.e. with spkg-configure checking their presence, but without real spkg-install), right?

That's right. Likewise for libxml in #30899.

should this be done on this ticket, or rather elsewhere?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 18, 2020

comment:11

Fine to do it here if it's not holding up this ticket too long

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 3, 2020

comment:13

Replying to @mkoeppe:

Likewise for libxml in #30899.

This is now done in #27921

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 4, 2020

comment:14

Needs review

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

Changed keywords from none to sd111

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

comment:15

Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111

@seblabbe
Copy link
Contributor

seblabbe commented Dec 9, 2020

comment:16

The branch has a conflict on top of 9.3.beta3 (I confirm there is one)

@seblabbe
Copy link
Contributor

seblabbe commented Dec 9, 2020

Work Issues: branch has conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 10, 2020

Changed commit from afdd20f to bdd5b9d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 10, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

bdd5b9dMerge tag '9.3.beta3' into t/30930/add_update_the_system_package_information_for_the___recommended__dummy_package

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2020

Changed work issues from branch has conflict to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 11, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 11, 2020

comment:21

Replying to @seblabbe:

Could we update the description of the ticket (which is too large), because I don't know what the branch is suppose to do exactly?

I have instead split out the pandoc part (which is the only thing that the current branch took care of) out into the separate ticket #31042.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 11, 2020

Changed dependencies from #30910 to #30910, #31042

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 11, 2020

Changed author from Matthias Koeppe to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2021

comment:23

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@slel
Copy link
Member

slel commented Mar 22, 2021

comment:24

Should _recommended really be listed in this configure notice?

    notice: the following SPKGs did not find equivalent system packages:

        _recommended cbc coxeter3 gp2c ...

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 22, 2021

comment:25

Yes, it may look funny but at least one can see that way where the system package recommendations are coming from

@slel
Copy link
Member

slel commented Mar 22, 2021

comment:26

Makes sense.

@dimpase
Copy link
Member

dimpase commented May 28, 2021

comment:27

texinfo keeps popping up on Homebrew for some reason --- perhaps, because texinfo is not a program, there no such executable anymore, it's replaced by tex2any - but the package name remains texinfo.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 28, 2021

comment:28

From the ticket description:
To this end, tests need to be added for the presence of the various recommended packages in the system. Either in build/pkgs/_recommended/spkg-configure.m4 or in individual script packages similar to build/pkgs/pandoc.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021
@seblabbe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 23, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 17, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
@mkoeppe mkoeppe closed this as completed Jun 22, 2024
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants