Add spkg-configure.m4 for 4ti2, remove direct use of SAGE_LOCAL #30887

mkoeppe · 2020-11-11T01:24:52Z

Part of #27330.

In addition to adjustments to src/sage/interfaces/four_ti_2.py, also the following needs changing:

src/sage/sandpiles/sandpile.py:path_to_zsolve = os.path.join(SAGE_LOCAL, 'bin', 'zsolve')

https://repology.org/project/4ti2/versions

CC: @dimpase @orlitzky @slel @antonio-rojas @kiwifb @jengelh @kwankyu @seblabbe

Component: packages: optional

Keywords: 4ti2, spkg-configure.m4

Author: Samuel Lelièvre, Matthias Koeppe

Branch/Commit: 646e182

Reviewer: Dima Pasechnik, Antonio Rojas

Issue created by migration from https://trac.sagemath.org/ticket/30887

The text was updated successfully, but these errors were encountered:

slel · 2021-03-22T01:42:45Z

Commit: d79e1c1

slel · 2021-03-22T01:42:45Z

Changed keywords from none to 4ti2, spkg-configure.m4

slel · 2021-03-22T01:42:45Z

Author: Samuel Lelièvre, ...

slel · 2021-03-22T01:42:45Z

Branch: public/30887

slel · 2021-03-22T01:42:45Z

comment:1

Here is distro information to get things started.

New commits:

`d79e1c1`	`30887: Add distro info for 4ti2`

mkoeppe · 2021-03-23T19:09:22Z

comment:2

latte_int uses 4ti2 as a library. The test is here: https://github.com/latte-int/latte/blob/master/m4/4ti2-check.m4#L48

mkoeppe · 2021-03-23T19:11:25Z

comment:3

Also Py4ti2 (to be added in #31363) uses 4ti2 as a library - https://github.com/alfsan/Py4ti2/blob/master/setup.py

mkoeppe · 2021-03-23T19:15:39Z

comment:4

singular is able to use 4ti2 via the command-line interface. Checks are done in https://github.com/Singular/Singular/blob/spielwiese/configure.ac#L352

configure.ac:AC_CHECK_PROGS([FOURTITWO_HILBERT], [hilbert 4ti2-hilbert])
configure.ac:AC_CHECK_PROGS([FOURTITWO_MARKOV], [markov 4ti2-markov])
configure.ac:AC_CHECK_PROGS([FOURTITWO_GRAVER], [graver 4ti2-graver])

mkoeppe · 2021-03-23T19:19:43Z

comment:5

src/sage/interfaces/four_ti_2.py calls the executables

$ grep call src/sage/interfaces/four_ti_2.py
    def call(self, command, project, verbose=True):
            sage: four_ti_2.call("groebner", "test_file", False) # optional - 4ti2
        subprocess.call(cmd, shell=True, cwd=self.directory())
        self.call('zsolve -q', project)
        self.call('qsolve -q -parbitrary', project)
        self.call('rays -q -parbitrary', project)
        self.call('hilbert -q', project)
        self.call('graver -q', project)
        self.call('ppi 2> /dev/null', n)
        self.call('circuits -q -parbitrary', project)
        self.call('groebner -q -parbitrary', project)

and does not know that Debian installs them with an executable prefix.

mkoeppe · 2021-03-23T20:20:58Z

comment:6

polymake calls the executables groebner, zsolve, circuits, which are configurable (https://github.com/polymake/polymake/blob/c2a326f240b11a06e1b1d5fd1c2ca7278bbe60a2/apps/polytope/rules/_4ti2.rules) but it does not know that Debian installs them with an executable prefix

mkoeppe · 2021-03-23T22:11:08Z

Dependencies: #31534

sagetrac-git · 2021-03-23T23:52:21Z

Changed commit from d79e1c1 to 602ffb0

sagetrac-git · 2021-03-23T23:52:21Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`7c272ec`	`Add MacPorts package info`
`8c9f53c`	`30504: Add _recommended package info for MacPorts`
`bf0a4d2`	`30504: Use zmq-devel in MacPorts for zeromq`
`e424489`	`30504: Fix gcc gfortran openblas info for MacPorts`
`b8b7092`	`build/pkgs/{gcc,gfortran}/distros/macports.txt: Fixup`
`4acfc5c`	`Merge #30504`
`857b7d5`	`tox.ini: In -maximal environments, use IGNORE_MISSING_SYSTEM_PACKAGES=yes for all non-current distributions`
`4e561ac`	`tox.ini: Use IGNORE_MISSING_SYSTEM_PACKAGES=no for rolling distributions, but IGNORE_MISSING_SYSTEM_PACKAGES=yes for unstable distributions`
`30d0e8a`	`Merge #31534`
`602ffb0`	`build/pkgs/4ti2/spkg-configure.m4: New`

sagetrac-git · 2021-03-24T02:20:59Z

Changed commit from 602ffb0 to ff25e8f

sagetrac-git · 2021-03-24T02:20:59Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ff25e8f`	`build/pkgs/4ti2/spkg-configure.m4: Fix quoting`

sagetrac-git · 2021-06-23T23:40:54Z

Changed commit from ff25e8f to dd364a5

sagetrac-git · 2021-06-23T23:40:54Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`0f13173`	`30887: Add distro info for 4ti2`
`1c1c1c8`	`build/pkgs/4ti2/spkg-configure.m4: New`
`dd364a5`	`build/pkgs/4ti2/spkg-configure.m4: Fix quoting`

mkoeppe · 2021-06-23T23:41:08Z

Changed dependencies from #31534 to none

sagetrac-git · 2021-06-23T23:57:40Z

Branch pushed to git repo; I updated commit sha1. New commits:

`45f8e59`	`build/pkgs/4ti2/spkg-configure.m4: Check for executables with prefix '4ti2-' too`
`390c0d2`	`build/pkgs/sage_conf/src/sage_conf.py.in, src/sage/env.py: Add FOURTITWO... variables`

sagetrac-git · 2021-06-23T23:57:40Z

Changed commit from dd364a5 to 390c0d2

mkoeppe · 2021-06-23T23:58:25Z

comment:14

On ubuntu-focal-maximal:

Checking whether SageMath should install SPKG 4ti2...
checking whether any of gmp mpir glpk zlib is installed as or will be installed as SPKG... no
checking for hilbert... no
checking for 4ti2-hilbert... 4ti2-hilbert
checking for markov... no
checking for 4ti2-markov... 4ti2-markov
checking for graver... no
checking for 4ti2-graver... 4ti2-graver
checking for zsolve... no
checking for 4ti2-zsolve... 4ti2-zsolve
checking for qsolve... no
checking for 4ti2-qsolve... 4ti2-qsolve
checking for rays... no
checking for 4ti2-rays... 4ti2-rays
checking for ppi... no
checking for 4ti2-ppi... 4ti2-ppi
checking for circuits... no
checking for 4ti2-circuits... 4ti2-circuits
checking for groebner... no
checking for 4ti2-groebner... 4ti2-groebner
checking for library 4ti2gmp... no
configure: no suitable system package found for SPKG 4ti2

mkoeppe · 2021-06-24T00:02:54Z

comment:15

Ubuntu packaging does not have the headers and has the shared libs in a nonstandard place - can't use

mkoeppe · 2021-07-19T18:30:03Z

comment:40

Thanks!

vbraun · 2021-07-21T20:19:25Z

comment:41

Tests fail

dimpase · 2021-07-21T22:59:55Z

comment:42

Volker, there are dozens of different ways external packages, vendored or not, with dependencies, may fail. More info please.

sagetrac-git · 2021-07-25T05:08:52Z

Changed commit from 1b8634d to d9d4f99

sagetrac-git · 2021-07-25T05:08:52Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d9d4f99`	`Merge tag '9.4.beta6' into t/30887/public/30887`

mkoeppe · 2021-07-25T05:10:27Z

comment:44

Works fine with and without 4ti2 installed. If there is a failure on some machine, we obviously need more information than "tests fail".

vbraun · 2021-07-25T20:26:28Z

comment:45

sage -t --long --warn-long 43.6 --random-seed=0 src/sage/misc/dev_tools.py
**********************************************************************
File "src/sage/misc/dev_tools.py", line 487, in sage.misc.dev_tools.import_statements
Failed example:
    import_statements('SAGE_ENV')
Expected:
    from sage.env import SAGE_ENV
Got:
    # ** Warning **: several modules for the object {'UNAME': 'Linux', 'HOSTNAME': 'zen', 'LOCAL_IDENTIFIER': 'zen.1421426', 'SAGE_VERSION': '9.4.beta6', 'SAGE_DATE': '2021-07-24', 'SAGE_VERSION_BANNER': 'SageMath version 9.4.beta6, Release Date: 2021-07-24', 'SAGE_VENV': '/home/release/Sage/local', 'SAGE_LIB': '/home/release/Sage/local/lib64/python3.9/site-packages', 'SAGE_EXTCODE': '/home/release/Sage/local/lib64/python3.9/site-packages/sage/ext_data', 'SAGE_VENV_SPKG_INST': '/home/release/Sage/local/var/lib/sage/installed', 'SAGE_LOCAL': '/home/release/Sage/local', 'SAGE_SHARE': '/home/release/Sage/local/share', 'SAGE_DOC': '/home/release/Sage/local/share/doc/sage', 'SAGE_SPKG_INST': '/home/release/Sage/local/var/lib/sage/installed', 'SAGE_ROOT': '/home/release/Sage', 'SAGE_SRC': '/home/release/Sage/src', 'SAGE_DOC_SRC': '/home/release/Sage/src/doc', 'SAGE_PKGS': '/home/release/Sage/build/pkgs', 'SAGE_ROOT_GIT': '/home/release/Sage/.git', 'DOT_SAGE': '/home/release/.sage/', 'SAGE_STARTUP_FILE': '/home/release/.sage/init-doctests.sage', 'SAGE_ARCHFLAGS': 'unset', 'SAGE_PKG_CONFIG_PATH': '/home/release/Sage/local/lib/pkgconfig', 'CONWAY_POLYNOMIALS_DATA_DIR': '/home/release/Sage/local/share/conway_polynomials', 'GRAPHS_DATA_DIR': '/home/release/Sage/local/share/graphs', 'ELLCURVE_DATA_DIR': '/home/release/Sage/local/share/ellcurves', 'POLYTOPE_DATA_DIR': '/home/release/Sage/local/share/reflexive_polytopes', 'GAP_ROOT_DIR': '/home/release/Sage/local/share/gap', 'THEBE_DIR': '/home/release/Sage/local/share/thebe', 'COMBINATORIAL_DESIGN_DATA_DIR': '/home/release/Sage/local/share/combinatorial_designs', 'CREMONA_MINI_DATA_DIR': '/home/release/Sage/local/share/cremona', 'CREMONA_LARGE_DATA_DIR': '/home/release/Sage/local/share/cremona', 'JMOL_DIR': '/home/release/Sage/local/share/jmol', 'MATHJAX_DIR': '/home/release/Sage/local/share/mathjax', 'MTXLIB': '/home/release/Sage/local/share/meataxe', 'THREEJS_DIR': '/home/release/Sage/local/share/threejs-sage', 'PPLPY_DOCS': '/home/release/Sage/local/share/doc/pplpy', 'MAXIMA': '/home/release/Sage/local/bin/maxima', 'MAXIMA_FAS': '/home/release/Sage/local/lib/ecl/maxima.fas', 'KENZO_FAS': '/home/release/Sage/local/lib/ecl/kenzo.fas', 'SAGE_NAUTY_BINS_PREFIX': '', 'FOURTITWO_HILBERT': '', 'FOURTITWO_MARKOV': '', 'FOURTITWO_GRAVER': '', 'FOURTITWO_ZSOLVE': '', 'FOURTITWO_QSOLVE': '', 'FOURTITWO_RAYS': '', 'FOURTITWO_PPI': '', 'FOURTITWO_CIRCUITS': '', 'FOURTITWO_GROEBNER': '', 'ARB_LIBRARY': 'arb', 'CBLAS_PC_MODULES': 'cblas', 'ECL_CONFIG': '/home/release/Sage/local/bin/ecl-config', 'NTL_INCDIR': '', 'NTL_LIBDIR': '', 'LIE_INFO_DIR': '/home/release/Sage/local/lib/LiE', 'OPENMP_CFLAGS': '-fopenmp', 'OPENMP_CXXFLAGS': '-fopenmp', 'SAGE_BANNER': '', 'SAGE_IMPORTALL': 'yes', 'SINGULAR_SO': '/home/release/Sage/local/lib/libSingular-4.2.0.so', 'GAP_SO': '/home/release/Sage/local/lib/libgap.so.0.0.0'}: sage.all, sage.all_cmdline, sage.env, sage.features.four_ti_2, sage.repl.ipython_kernel.all_jupyter
    from sage.env import SAGE_ENV
**********************************************************************
1 item had failures:
   1 of  37 in sage.misc.dev_tools.import_statements
    [60 tests, 1 failure, 0.22 s]
----------------------------------------------------------------------
sage -t --long --warn-long 43.6 --random-seed=0 src/sage/misc/dev_tools.py  # 1 doctest failed
----------------------------------------------------------------------

sagetrac-git · 2021-07-25T20:51:28Z

Branch pushed to git repo; I updated commit sha1. New commits:

`646e182`	src/sage/features/four_ti_2.py: Move import of SAGE_ENV inside the `__init__` method, to remove confusion of sage.misc.dev_tools

sagetrac-git · 2021-07-25T20:51:28Z

Changed commit from d9d4f99 to 646e182

mkoeppe · 2021-07-25T20:51:42Z

comment:47

Thanks, fixed.

mkoeppe · 2021-10-03T21:49:29Z

comment:49

Let's get this in please.

antonio-rojas · 2021-10-04T20:16:30Z

comment:50

All good here with both distro packaging and building from source against system 4ti2

antonio-rojas · 2021-10-04T20:16:30Z

Changed reviewer from Dima Pasechnik to Dima Pasechnik, Antonio Rojas

mkoeppe · 2021-10-04T20:51:15Z

comment:51

Thank you!

vbraun · 2021-10-10T10:17:14Z

Changed branch from public/30887 to 646e182

mkoeppe added this to the sage-9.3 milestone Nov 11, 2020

mkoeppe added c: packages: optional labels Nov 11, 2020

This comment has been minimized.

Sign in to view

slel changed the title ~~spkg-configure.m4 for 4ti2~~ Add spkg-configure.m4 for 4ti2 Mar 22, 2021

mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 28, 2021

vbraun added s: needs work and removed s: positive review labels Jul 21, 2021

mkoeppe added s: positive review and removed s: needs work labels Jul 25, 2021

vbraun added s: needs work and removed s: positive review labels Jul 25, 2021

mkoeppe added s: needs review and removed s: needs work labels Jul 25, 2021

mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021

antonio-rojas added s: positive review and removed s: needs review labels Oct 4, 2021

vbraun removed the s: positive review label Oct 10, 2021

vbraun closed this as completed in eb7699a Oct 10, 2021

embray mentioned this issue Jan 29, 2023

Meta-ticket: spkg-configure: Try to use as many system packages as possible #27330

Open

Add spkg-configure.m4 for 4ti2, remove direct use of SAGE_LOCAL #30887

Add spkg-configure.m4 for 4ti2, remove direct use of SAGE_LOCAL #30887

Comments

mkoeppe commented Nov 11, 2020

slel commented Mar 22, 2021

slel commented Mar 22, 2021

This comment has been minimized.

slel commented Mar 22, 2021

slel commented Mar 22, 2021

slel commented Mar 22, 2021

mkoeppe commented Mar 23, 2021

mkoeppe commented Mar 23, 2021

mkoeppe commented Mar 23, 2021

mkoeppe commented Mar 23, 2021

mkoeppe commented Mar 23, 2021

mkoeppe commented Mar 23, 2021

sagetrac-git mannequin commented Mar 23, 2021

sagetrac-git mannequin commented Mar 23, 2021

sagetrac-git mannequin commented Mar 24, 2021

sagetrac-git mannequin commented Mar 24, 2021

sagetrac-git mannequin commented Jun 23, 2021

sagetrac-git mannequin commented Jun 23, 2021

mkoeppe commented Jun 23, 2021

sagetrac-git mannequin commented Jun 23, 2021

sagetrac-git mannequin commented Jun 23, 2021

mkoeppe commented Jun 23, 2021

mkoeppe commented Jun 24, 2021

mkoeppe commented Jul 19, 2021

vbraun commented Jul 21, 2021

dimpase commented Jul 21, 2021

sagetrac-git mannequin commented Jul 25, 2021

sagetrac-git mannequin commented Jul 25, 2021

mkoeppe commented Jul 25, 2021

vbraun commented Jul 25, 2021

sagetrac-git mannequin commented Jul 25, 2021

sagetrac-git mannequin commented Jul 25, 2021

mkoeppe commented Jul 25, 2021

mkoeppe commented Oct 3, 2021

antonio-rojas commented Oct 4, 2021

antonio-rojas commented Oct 4, 2021

mkoeppe commented Oct 4, 2021

vbraun commented Oct 10, 2021