Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pillow to 7.2.0 #30185

Closed
mkoeppe opened this issue Jul 21, 2020 · 10 comments
Closed

Upgrade pillow to 7.2.0 #30185

mkoeppe opened this issue Jul 21, 2020 · 10 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 21, 2020

(from #30103)

On this ticket:

CC: @jhpalmieri @antonio-rojas @dimpase @orlitzky

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 2cbfdf2

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/30185

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jul 21, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 21, 2020

Branch: u/mkoeppe/upgrade_pillow_to_7_2_0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 21, 2020

Commit: 2cbfdf2

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 21, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 21, 2020

New commits:

2cbfdf2build/pkgs/pillow: Update to 7.2.0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 22, 2020

@jhpalmieri
Copy link
Member

comment:4

It looks okay to me, but I'm not sure what function Pillow serves within Sage, so it's hard to know if it's actually working. I did try it with the new matplotlib, which apparently uses it instead of libpng for all of its plotting, and things looked good when I created some sample plots. I'm going to mark it as "positive review" since it's an upgrade to an existing package and it appears to work.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 27, 2020

comment:5

Thanks! Yes, as far as I know, it's only used by matplotlib.

@DaveWitteMorris
Copy link
Member

comment:6

FWIW: My search of the src directory indicates that SageTeX is the only other package that has pillow as a dependency.

@vbraun
Copy link
Member

vbraun commented Aug 2, 2020

Changed branch from u/mkoeppe/upgrade_pillow_to_7_2_0 to 2cbfdf2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants