Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make crypto doctests ready for random seeds #29980

Closed
kliem opened this issue Jun 24, 2020 · 22 comments
Closed

Make crypto doctests ready for random seeds #29980

kliem opened this issue Jun 24, 2020 · 22 comments

Comments

@kliem
Copy link
Contributor

kliem commented Jun 24, 2020

This ticket makes

sage -t --long --random-seed=n src/sage/crypto/

pass for different values n than just 0.

Component: doctest framework

Author: Jonathan Kliem

Branch/Commit: 05d474e

Reviewer: Markus Wageringel

Issue created by migration from https://trac.sagemath.org/ticket/29980

@kliem kliem added this to the sage-9.2 milestone Jun 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Commit: 2a96462

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Branch: public/29980

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

New commits:

da1c6bestart from a "random" random seed for doctesting
b7b836dmake random seed reproducible
eedbe5edocument random_seed
998b1b9default random seed 0 for now
1d7b00edash instead of underscore for command line options
2a96462make crypto fuzz ready

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Author: Jonathan Kliem

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

comment:3

Merge conflict.

I also need to go through it again and check I respected the design decision in #29935.

@kliem
Copy link
Contributor Author

kliem commented Jul 21, 2020

Changed commit from 2a96462 to 0b128d8

@kliem
Copy link
Contributor Author

kliem commented Jul 21, 2020

New commits:

b31e2d5Merge branch 'public/29962' of git://trac.sagemath.org/sage into public/29962-reb
2f30dd9small fixes
b62f781doctests do not start from a random seed by default yet
1d99129fix merge conflict
0b128d8make crypto fuzz ready

@kliem
Copy link
Contributor Author

kliem commented Jul 21, 2020

Changed branch from public/29980 to public/29980-reb

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 13, 2021

comment:6

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@kliem
Copy link
Contributor Author

kliem commented Jun 30, 2021

New commits:

2a96462make crypto fuzz ready

@kliem
Copy link
Contributor Author

kliem commented Jun 30, 2021

Changed branch from public/29980-reb to public/29980

@kliem
Copy link
Contributor Author

kliem commented Jun 30, 2021

Changed commit from 0b128d8 to 2a96462

@kliem
Copy link
Contributor Author

kliem commented Jun 30, 2021

Changed dependencies from #29962 to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 30, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

432a400make crypto ready for fuzzed doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 30, 2021

Changed commit from 2a96462 to 432a400

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2021

Changed commit from 432a400 to 05d474e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

05d474e29980: tested property of carmichael_lambda only holds for k≥3

@mwageringel
Copy link

Reviewer: Markus Wageringel

@mwageringel
Copy link

comment:10

This looks good to me. I have fixed one more test of a property which, according to its documentation, only holds for k>=3.

We could also remove the calls of set_random_seed(1337) in lwe.py, though either way is fine with me. You can set a positive review on my behalf.

@kliem
Copy link
Contributor Author

kliem commented Jul 8, 2021

comment:11

Thank you.

I think we should remove those set_random_seed's as a follow up to #29935.

@mwageringel
Copy link

comment:12

Ok, that sounds good to me.

@vbraun
Copy link
Member

vbraun commented Jul 18, 2021

Changed branch from public/29980 to 05d474e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants