Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.categories.pushout.type_to_parent: Reimplement using py_scalar_parent #29880

Closed
mkoeppe opened this issue Jun 17, 2020 · 9 comments
Closed

sage.categories.pushout.type_to_parent: Reimplement using py_scalar_parent #29880

mkoeppe opened this issue Jun 17, 2020 · 9 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.2

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 17, 2020

type_to_parent seems to be a less complete implementation of py_scalar_parent.

The change on this ticket helps get rid some explicit imports from sage.rings.

CC: @tscrim @mezzarobba

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 4b37cc6

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29880
@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 17, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 17, 2020

Branch: u/mkoeppe/sage_categories_pushout_type_to_parent__reimplement_using_py_scalar_parent

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 17, 2020

New commits:

4b37cc6sage.categories.pushout.type_to_parent: Reimplement using py_scalar_parent

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 17, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 17, 2020

Commit: 4b37cc6

@tscrim
Copy link
Collaborator

tscrim commented Jun 17, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 17, 2020

comment:3

A good example of needing to DRY things out. ahem

Green patchbot => positive review.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 17, 2020

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 2, 2020

Changed branch from u/mkoeppe/sage_categories_pushout_type_to_parent__reimplement_using_py_scalar_parent to 4b37cc6

@vbraun vbraun closed this as completed in 9966288 Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mkoeppe