Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularization of sagelib: Create package sage-tdlib #29864

Closed
mkoeppe opened this issue Jun 15, 2020 · 33 comments
Closed

Modularization of sagelib: Create package sage-tdlib #29864

mkoeppe opened this issue Jun 15, 2020 · 33 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 15, 2020

The new package sage-tdlib represents the old OptionalExtension sage.graphs.graph_decompositions.tdlib (building upon #29701, #28925). We use it as a second an example package for the modularization after sage-meataxe (#30151).

It does not use the incremental install mechanism of sagelib (sage_setup.command.sage_install.sage_install_and_clean). It uses a simple setuptools build system.

This is part of #29705: Meta-ticket: Modularize sagelib into separate distributions (distutils packages)

Depends on #34346

CC: @tobiasdiez

Component: build

Keywords: sd111

Work Issues: rebase

Branch/Commit: u/mkoeppe/modularization-sage-tdlib @ 16a9b2e

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/29864

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 15, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 15, 2020

Branch: u/mkoeppe/modularization-sage-tdlib

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 15, 2020

Commit: 2ccf6b7

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 15, 2020

Last 10 new commits:

7dd469fWIP: Add sage_tdlib package, use symlinks for sagelib package
24e9b30build/pkgs/sage_tdlib/src/MANIFEST.in: New
9b59435fixup symlinks
c3593b2build/pkgs/sage_tdlib/src/sage_setup: Remove, we use the installed one
2612091Use setup.py install --single-version-externally-managed
458d851build/pkgs/sage_tdlib/spkg-src: New
5d4e8e7build/pkgs/sage_tdlib/dependencies: Add sagelib, python toolchain
7042564build/pkgs/sagelib/spkg-src: New
90b33d8Install sagelib, sage_tdlib via sdist defined by MANIFEST.in
2ccf6b7Merge tag '9.2.beta1' into t/29705/META-modularize-sagelib

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Jun 15, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2020

Work Issues: rebase

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2020

Changed work issues from rebase to rebase; create sage-core; don't change sagelib

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 18, 2020

Changed dependencies from #29702, #29701, #28197, #28925, #29803 to #28925

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Modularization of sagelib: Break out a separate package sage-tdlib Modularization of sagelib: Create modular packages sage-core, sage-tdlib Sep 8, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 9, 2020

Changed dependencies from #28925 to #28925, #29847

@mkoeppe

This comment has been minimized.

@tobiasdiez
Copy link
Contributor

comment:9

Just for clarification, was is sage-lib and what sage-core?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2020

Changed commit from 2ccf6b7 to bf1c011

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

e8d1a23src/setup.py: from setuptools import setup
c99dab5Add src/setup.cfg
67189baWIP: Add sage_tdlib package, use symlinks for sagelib package
5d85487build/pkgs/sage_tdlib/src/MANIFEST.in: New
bf5dddcfixup symlinks
6d5e4f5build/pkgs/sage_tdlib/src/sage_setup: Remove, we use the installed one
4cd5176Use setup.py install --single-version-externally-managed
577f338build/pkgs/sage_tdlib/spkg-src: New
8b972d7build/pkgs/sage_tdlib/dependencies: Add sagelib, python toolchain
bf1c011Install sagelib, sage_tdlib via sdist defined by MANIFEST.in

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2020

Changed commit from bf1c011 to 59a33de

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

2e61adasage.numerical.backends: Make it a namespace package by removing __init__.py (which was empty)
26b1ca0Mark src and src/sage/ext_data as directories that are not namespace packages
a733af5sage_setup.find.find_python_sources: Handle native namespace packages, 'nonamespace' files
c08c511is_package_or_namespace_package_dir: New, recognize namespace packages by file 'namespace', monkeypatch into Cython
4407e5esage_setup.command.sage_install.sage_install: Rename to sage_install_and_clean, update use it in src/setup.py; refactor through new class sage_install
a13c126Make sage.graphs, sage.matrix, sage.libs, sage.interfaces namespace packages
a967acaWIP
c746965sage_setup/command/sage_install.py: WIP: Disable cleaning
6ba4212WIP: Add sage_tdlib package, use symlinks for sagelib package
59a33deInstall sagelib, sage_tdlib via sdist defined by MANIFEST.in

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 10, 2020

Changed dependencies from #28925, #29847 to #28925, #29500, #29847

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2020

Changed commit from 59a33de to 16a9b2e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a315ba6Merge branch 't/28925/modify_find_python_sources__clean_stale_files_to_support_modularization_of_sagelib_by_native_namespace_packages__pep_420_' into t/29864/modularization-sage-tdlib
4a30688WIP: Add sage_tdlib package, use symlinks for sagelib package
16a9b2eInstall sagelib, sage_tdlib via sdist defined by MANIFEST.in

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 10, 2020

comment:14

Rebased on top of #28925, cleaned out a lot of old code.

Next step: Finish #28925 (see "work issues" there).

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

Changed keywords from none to sd111

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

comment:16

Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2020

comment:17

Simplified this ticket.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2020

Changed dependencies from #28925, #29500, #29847 to #30151

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2020

Changed work issues from rebase; create sage-core; don't change sagelib to rebase

@mkoeppe mkoeppe changed the title Modularization of sagelib: Create modular packages sage-core, sage-tdlib Modularization of sagelib: Create package sage-tdlib Dec 9, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2021

comment:18

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 16, 2022

Changed dependencies from #30151 to #34346

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 16, 2022

comment:23

This is now done as part of #34346.

@mkoeppe mkoeppe removed this from the sage-9.8 milestone Nov 16, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 16, 2022

Changed author from Matthias Koeppe to none

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 10, 2022

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 10, 2022

comment:25

Okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants