Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper fix for "fedora-30-standard: Doctests using system brial crash" #29792

Closed
dimpase opened this issue Jun 4, 2020 · 6 comments
Closed

Comments

@dimpase
Copy link
Member

dimpase commented Jun 4, 2020

This is a followup to #29490.

We now add code rejecting Brial 1.2.5 - provided it can
be recognised from VERSION macro in polybory/config.h header.
This identifies standard Brial on Fedora 30 (and possibly elsewhere, but tough luck then).

CC: @orlitzky @mkoeppe

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: 1ef1f87

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29792

@dimpase dimpase added this to the sage-9.2 milestone Jun 4, 2020
@kliem
Copy link
Contributor

kliem commented Jun 5, 2020

comment:3

Seems to work fine.

https://github.com/kliem/sage-test-27122/actions/runs/125137242

It rejects brial on fedora 30 and 31 and ubuntu eoan (all use Brial 1.2.5).

It doesn't reject Brial 1.2.4 on debian buster and Brial 1.2.7 on ubuntu focal.

@dimpase
Copy link
Member Author

dimpase commented Jun 5, 2020

comment:4

it also accepts brial 1.2.8 on Gentoo lunux.

@kliem
Copy link
Contributor

kliem commented Jun 6, 2020

comment:5

I think this is good to go.

@kliem
Copy link
Contributor

kliem commented Jun 6, 2020

Reviewer: Jonathan Kliem

@vbraun
Copy link
Member

vbraun commented Jun 27, 2020

Changed branch from u/dimpase/packages/brialconfigfix to 1ef1f87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants