Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgconfig should depend on pkgconf #29449

Closed
jhpalmieri opened this issue Apr 2, 2020 · 12 comments
Closed

pkgconfig should depend on pkgconf #29449

jhpalmieri opened this issue Apr 2, 2020 · 12 comments

Comments

@jhpalmieri
Copy link
Member

As the summary says.

If I run "make numpy" on a system without its own pkg-config, the build fails. If I install Sage's pkgconf first, it works. numpy depends on pkgconfig, the Python interface to pkgconf, but pkgconfig really only makes sense if pkgconf (or a system-wide equivalent) is available.

Component: build

Author: John Palmieri

Branch/Commit: ba07bfb

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29449

@jhpalmieri jhpalmieri added this to the sage-9.1 milestone Apr 2, 2020
@jhpalmieri
Copy link
Member Author

@jhpalmieri
Copy link
Member Author

New commits:

eb136aetrac 29449: numpy should depend on pkgconf

@jhpalmieri
Copy link
Member Author

Commit: eb136ae

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 2, 2020

comment:3

Shouldn't rather pkgconfig depend on pkgconf?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 2, 2020

Changed commit from eb136ae to ba07bfb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 2, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ba07bfbtrac 29449: pkgconfig should depend on pkgconf

@jhpalmieri

This comment has been minimized.

@jhpalmieri
Copy link
Member Author

comment:5

Logically that makes sense, but I only see the problem with numpy. (pkgconfig doesn't need pkgconf or a system-wide pkg-config to build, but it needs it to do anything.)

@jhpalmieri jhpalmieri changed the title numpy should depend on pkgconf pkgconfig should depend on pkgconf Apr 2, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 2, 2020

comment:6

Replying to @jhpalmieri:

Logically that makes sense, but I only see the problem with numpy. (pkgconfig doesn't need pkgconf or a system-wide pkg-config to build, but it needs it to do anything.)

Right. Because pkgconfig is a very small package, I don't think we need to distinguish its build-time and run-time dependencies. Adding the dependency there is clearer, even if right now only numpy exposes the problem.

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 2, 2020

Reviewer: Matthias Koeppe

@jhpalmieri
Copy link
Member Author

comment:7

Great, thanks!

@vbraun
Copy link
Member

vbraun commented Apr 9, 2020

Changed branch from u/jhpalmieri/numpy-depends-on-pkgconf to ba07bfb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants