-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use solve_left for division operation of matrices #29257
Comments
Branch: u/gh-mwageringel/29257 |
Author: Markus Wageringel |
Dependencies: #12406 |
comment:1
Based on #12406. New commits:
|
Commit: |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:3
Now this also passes the tests with Python 2. |
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
|
comment:5
Rebased on top of #12406. |
comment:6
Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Jonathan Kliem |
comment:8
LGTM. |
comment:9
Thank you. There was a related discussion in #29226 which has not been crosslinked here yet. IMHO, this is still an improvement over the current behavior, but it is okay if you would like to reconsider the review. |
comment:10
I see. Of course we can remove division of matrices, but even our documentation https://doc.sagemath.org/html/en/tutorial/tour_linalg.html For the time being it's an improvement. Even if we want to get rid of it eventually, at this point we could raise a deprecation error more easily and say, "use solve left/right instead". |
comment:11
Ok, sounds good to me. |
Changed branch from u/gh-mwageringel/29257 to |
This ticket improves the
__truediv__
division operation of matrices and vectors by implementing it usingsolve_left
(the_backslash_
operator is already implemented usingsolve_right
).Currently,
__truediv__
only works for square matrices with the same parent. The implementation naively computes the inverse of a matrix, which should be avoided, especially over inexact rings.With the changes of this ticket (and #12406), the operation works over differing rings and even with non-square matrices.
Depends on #12406
Component: linear algebra
Author: Markus Wageringel
Branch/Commit:
653849a
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/29257
The text was updated successfully, but these errors were encountered: