Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

barvinok spkg-install syntax error #27751

Closed
jdemeyer opened this issue Apr 30, 2019 · 8 comments
Closed

barvinok spkg-install syntax error #27751

jdemeyer opened this issue Apr 30, 2019 · 8 comments
Labels
c: packages: optional p: blocker / 1 t: bug
Milestone
sage-8.8

Comments

@jdemeyer
Copy link

#27212 introduced a syntax error in build/pkgs/barvinok/spkg-install:

./spkg-install: line 37: syntax error near unexpected token `fi'
./spkg-install: line 37: `fi'

CC: @embray

Component: packages: optional

Author: Dima Pasechnik

Branch/Commit: e758967

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/27751
@jdemeyer jdemeyer added this to the sage-8.8 milestone Apr 30, 2019
@dimpase
Copy link
Member

dimpase commented Apr 30, 2019

comment:1

line 37? Are you sure? There are not so many lines there...
https://github.com/sagemath/sage-prod/blob/develop/build/pkgs/barvinok/spkg-install
has 13 lines

@dimpase
Copy link
Member

dimpase commented Apr 30, 2019

comment:2

oops, I see. missing then in if.

@dimpase
Copy link
Member

dimpase commented Apr 30, 2019

Author: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Apr 30, 2019

Branch: u/dimpase/packages/barvinokfix1

@dimpase
Copy link
Member

dimpase commented Apr 30, 2019

Commit: e758967

@dimpase
Copy link
Member

dimpase commented Apr 30, 2019

comment:3

this builds fine.

New commits:

e758967adding missing then in if

@jdemeyer
Copy link
Author

Reviewer: Jeroen Demeyer

@vbraun
Copy link
Member

vbraun commented May 6, 2019

Changed branch from u/dimpase/packages/barvinokfix1 to e758967

@vbraun vbraun closed this as completed in b978255 May 6, 2019
@dimpase dimpase mentioned this issue Jul 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
3 participants
@vbraun @dimpase @jdemeyer