Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use system's gf2x if available #27238

Closed
dimpase opened this issue Feb 8, 2019 · 16 comments
Closed

use system's gf2x if available #27238

dimpase opened this issue Feb 8, 2019 · 16 comments

Comments

@dimpase
Copy link
Member

dimpase commented Feb 8, 2019

the usual spkg-configure.m4 thing

CC: @embray @kiwifb

Component: packages: standard

Author: Dima Pasechnik

Branch: 844e241

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/27238

@dimpase dimpase added this to the sage-8.7 milestone Feb 8, 2019
@dimpase dimpase changed the title use system't gf2x if available use system's gf2x if available Feb 8, 2019
@dimpase
Copy link
Member Author

dimpase commented Feb 8, 2019

comment:2

the test is not sufficient to tell version 1.2 from 1.1

@dimpase
Copy link
Member Author

dimpase commented Feb 13, 2019

Dependencies: #27212

@dimpase
Copy link
Member Author

dimpase commented Feb 26, 2019

comment:5

One ought to be able to test for signature of a particular function in gf2x.h, which changed from 1.1 to 1.2.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 26, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a1ee9bdspkg-configure.m4 for gf2x
6b61156added a test for version >= 1.2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 26, 2019

Changed commit from dbd7476 to 6b61156

@dimpase
Copy link
Member Author

dimpase commented Feb 26, 2019

comment:7

gf2x takes long time to build, as it does tuning, so that's quite a building speedup.

@dimpase
Copy link
Member Author

dimpase commented Feb 26, 2019

Changed dependencies from #27212 to none

@kiwifb
Copy link
Member

kiwifb commented Feb 28, 2019

comment:10

Is there a mix of tabs and white spaces in that file? Just looking at it in the browser, I didn't checkout the branch. Other than that it looks sound and should do the trick.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 28, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

844e241whitespaces adjusted, tabs removed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 28, 2019

Changed commit from 6b61156 to 844e241

@dimpase
Copy link
Member Author

dimpase commented Feb 28, 2019

comment:12

fixed whitespaces now, sorry.

@kiwifb
Copy link
Member

kiwifb commented Feb 28, 2019

comment:13

Those things are quite clear on the diff but I think they are harmless in M4. Let's move on.

@kiwifb
Copy link
Member

kiwifb commented Feb 28, 2019

Reviewer: François Bissey

@vbraun
Copy link
Member

vbraun commented Mar 2, 2019

Changed branch from u/dimpase/packages/gf2x-config to 844e241

@dimpase
Copy link
Member Author

dimpase commented Mar 21, 2019

comment:15

I've provided the upstream with a PR to do a pkg-config configuration, so this could be simplified eventually. See
dimpase/gf2x@c7cd1f2
and
https://gforge.inria.fr/tracker/index.php?func=detail&aid=21746&group_id=1874&atid=6979

@dimpase
Copy link
Member Author

dimpase commented Mar 21, 2019

Changed commit from 844e241 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants