-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use system's gf2x if available #27238
Comments
comment:2
the test is not sufficient to tell version 1.2 from 1.1 |
Dependencies: #27212 |
comment:5
One ought to be able to test for signature of a particular function in gf2x.h, which changed from 1.1 to 1.2. |
comment:7
gf2x takes long time to build, as it does tuning, so that's quite a building speedup. |
Changed dependencies from #27212 to none |
comment:10
Is there a mix of tabs and white spaces in that file? Just looking at it in the browser, I didn't checkout the branch. Other than that it looks sound and should do the trick. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:12
fixed whitespaces now, sorry. |
comment:13
Those things are quite clear on the diff but I think they are harmless in M4. Let's move on. |
Reviewer: François Bissey |
Changed branch from u/dimpase/packages/gf2x-config to |
comment:15
I've provided the upstream with a PR to do a pkg-config configuration, so this could be simplified eventually. See |
Changed commit from |
the usual spkg-configure.m4 thing
CC: @embray @kiwifb
Component: packages: standard
Author: Dima Pasechnik
Branch:
844e241
Reviewer: François Bissey
Issue created by migration from https://trac.sagemath.org/ticket/27238
The text was updated successfully, but these errors were encountered: