Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid uses of sig_on() in matrix.misc #27224

Closed
jdemeyer opened this issue Feb 5, 2019 · 6 comments
Closed

Fix invalid uses of sig_on() in matrix.misc #27224

jdemeyer opened this issue Feb 5, 2019 · 6 comments
Labels
c: cython p: blocker / 1 t: bug
Milestone
sage-8.7

Comments

@jdemeyer
Copy link

jdemeyer commented Feb 5, 2019

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 85d25bf

Reviewer: Timo Kaufmann

Issue created by migration from https://trac.sagemath.org/ticket/27224
@jdemeyer jdemeyer added this to the sage-8.7 milestone Feb 5, 2019
@jdemeyer
Copy link
Author

jdemeyer commented Feb 5, 2019

Branch: u/jdemeyer/fix_invalid_uses_of_sig_on___in_matrix_misc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 5, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

85d25bfFix invalid uses of sig_on() in matrix.misc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 5, 2019

Commit: 85d25bf

@timokau
Copy link
Contributor

timokau commented Feb 5, 2019

comment:4

Thank you! Just encountered this recently and didn't even create a ticket yet. Yet you fixed it already :)

I'll test.

@timokau
Copy link
Contributor

timokau commented Feb 5, 2019

Reviewer: Timo Kaufmann

@vbraun
Copy link
Member

vbraun commented Feb 7, 2019

Changed branch from u/jdemeyer/fix_invalid_uses_of_sig_on___in_matrix_misc to 85d25bf

@vbraun vbraun closed this as completed in d1a99e1 Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cython p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @timokau