Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jupyter notebook 5.7.1 #26709

Closed
slel opened this issue Nov 17, 2018 · 8 comments
Closed

Upgrade to jupyter notebook 5.7.1 #26709

slel opened this issue Nov 17, 2018 · 8 comments

Comments

@slel
Copy link
Member

slel commented Nov 17, 2018

Quoting the release announcement for notebook 5.7.1:

The only change in this release is a security fix. An oversight in earlier versions
meant that using the 'print preview' feature on a malicious notebook could
allow it to run untrusted Javascript in the notebook server context. This
potentially means it could start a kernel and run code on your computer.

It's recommended to upgrade as soon as practical.

Our previous upgrade was to notebook 5.7.0 in #26174, so this should be easy.

CC: @kiwifb @jdemeyer @bryangingechen @slel

Component: packages: standard

Keywords: upgrade, jupyter, notebook

Author: Bryan Gin-ge Chen

Branch/Commit: fc9b8c3

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/26709

@slel slel added this to the sage-8.5 milestone Nov 17, 2018
@slel slel changed the title Upgrade to jupyter notebook 5.7.0 Upgrade to jupyter notebook 5.7.1 Nov 17, 2018
@bryangingechen
Copy link
Mannequin

bryangingechen mannequin commented Nov 17, 2018

Branch: public/notebook-5.7.1

@bryangingechen
Copy link
Mannequin

bryangingechen mannequin commented Nov 17, 2018

Commit: 8dafc4e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2018

Changed commit from 8dafc4e to fc9b8c3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

fc9b8c3Update notebook to 5.7.1

@vbraun
Copy link
Member

vbraun commented Nov 18, 2018

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Nov 18, 2018

Author: Samuel Lelièvre

@bryangingechen
Copy link
Mannequin

bryangingechen mannequin commented Nov 18, 2018

Changed author from Samuel Lelièvre to Bryan Gin-ge Chen

@vbraun
Copy link
Member

vbraun commented Nov 19, 2018

Changed branch from public/notebook-5.7.1 to fc9b8c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants