Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GAP 4.8.10 #24427

Closed
slel opened this issue Dec 25, 2017 · 27 comments
Closed

Upgrade to GAP 4.8.10 #24427

slel opened this issue Dec 25, 2017 · 27 comments

Comments

@slel
Copy link
Member

slel commented Dec 25, 2017

GAP 4.8.10 was released on 2018-01-15.

Release announcement:

GAP 4.8.10 page:

Changelog:

From SageMath 7.6.beta3 to the current SageMath 8.2.beta3,
we use GAP 4.8.6, introduced in #20914. Time to upgrade!

Tarball for GAP:

Tarballs for database_gap, gap_packages, libgap:

Note that #22626 will upgrade to the upcoming GAP 4.9,
but it would be nice to upgrade to GAP 4.8.10 for now.

CC: @dimpase @kiwifb @jdemeyer @slel @vbraun @timokau @sebasguts @nthiery @embray

Component: packages: standard

Keywords: GAP, database_gap, gap_packages, libgap

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24427

@slel slel added this to the sage-8.2 milestone Dec 25, 2017
@slel
Copy link
Member Author

slel commented Jan 18, 2018

comment:1

Changing the goal of this ticket from "GAP 4.8.9" to "GAP 4.8.10".

@slel

This comment has been minimized.

@slel slel changed the title Upgrade to GAP 4.8.9 Upgrade to GAP 4.8.10 Jan 18, 2018
@dimpase
Copy link
Member

dimpase commented Feb 17, 2018

comment:2

GAP 4.9 beta is already out.

https://www.gap-system.org/pub/gap/gap-4.9/beta/

@slel
Copy link
Member Author

slel commented Feb 17, 2018

comment:3

I suggest getting GAP 4.8.10 in Sage 8.2, if it's not too much work, since:

  • GAP 4.9 might still be in beta when Sage 8.2 is released.
  • GAP 4.9 has major changes, so Upgrade to GAP 4.10 #22626 (Upgrade to GAP 4.9) might take time.

@slel
Copy link
Member Author

slel commented Mar 26, 2018

comment:4

Although the release of GAP 4.9.1 is approaching, I don't know if it will still be a beta
or considered the official 4.9 release.

It might still be possible to get GAP 4.8.10 in Sage 8.2. What are the steps to produce
tarballs for database_gap, gap_packages, libgap?

@dimpase
Copy link
Member

dimpase commented Mar 26, 2018

comment:5

Replying to @slel:

Although the release of GAP 4.9.1 is approaching, I don't know if it will still be a beta
or considered the official 4.9 release.

It might still be possible to get GAP 4.8.10 in Sage 8.2. What are the steps to produce
tarballs for database_gap, gap_packages, libgap?

Updating libgap is potentially time-consuming and error-prone. See https://bitbucket.org/vbraun/libgap

@slel
Copy link
Member Author

slel commented Apr 26, 2018

comment:6

Replying to @dimpase:

Replying to @slel:

Although the release of GAP 4.9.1 is approaching, I don't know
if it will still be a beta or considered the official 4.9 release.

It might still be possible to get GAP 4.8.10 in Sage 8.2. What are the
steps to produce tarballs for database_gap, gap_packages, libgap?

Updating libgap is potentially time-consuming and error-prone. See
https://bitbucket.org/vbraun/libgap

Hard to know in advance, but one might hope that minor version bumps
in GAP would be relatively easy to deal with.

The upgrade to GAP 4.8.10 in the ArchLinux packaging of SageMath
seems pretty straightforward:

https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/libgap#n20

@dimpase
Copy link
Member

dimpase commented Apr 26, 2018

comment:7

This looks fishy - just version bumps...

@jdemeyer
Copy link

comment:8

Worse than fishy: plain wrong!

It looks like they took the 4.8.6 tarball and artificially renamed it 4.8.10.

@slel
Copy link
Member Author

slel commented Apr 29, 2018

comment:9

In Debian they use GAP 4.8.8, does that mean they produced libgap for 4.8.8?

@dimpase
Copy link
Member

dimpase commented Apr 29, 2018

comment:10

Replying to @slel:

In Debian they use GAP 4.8.8, does that mean they produced libgap for 4.8.8?

Probably they did. Last time I worked on upgrade to 4.8.6, I used Debian's work, IIRC.

@nthiery
Copy link
Contributor

nthiery commented May 1, 2018

Attachment: gap-4.8.10.tar.bz2.gz

gap 4.8.10 sources after running spkg-src

@nthiery
Copy link
Contributor

nthiery commented May 1, 2018

Branch: u/nthiery/upgrade_to_gap_4_8_10

@nthiery
Copy link
Contributor

nthiery commented May 1, 2018

comment:12

To get the ball rolling, I updated the GAP sources according to the instructions in the SPKG.
I haven't run the tests yet (rebuilding my Sage).


New commits:

3c56a1b24427: Upgrade to gap 4.8.10, first step: upgrade the sources
a54397124427: expanded upgrade instructions for gap's spkg

@nthiery
Copy link
Contributor

nthiery commented May 1, 2018

Commit: a543971

@tscrim
Copy link
Collaborator

tscrim commented May 1, 2018

comment:13

Just noting #13426, which adds more things to gap_packages.

@slel

This comment has been minimized.

@slel
Copy link
Member Author

slel commented May 1, 2018

comment:14

Sebastian Gutsche produced a tentative tarball for libgap-4.8.10:
https://bitbucket.org/sebasguts/libgap/downloads/libgap-4.8.10.tar.gz

@kiwifb
Copy link
Member

kiwifb commented May 2, 2018

comment:15

We should note that the only thing changing since 4.8.8 is the packages distributed with gap.
https://www.gap-system.org/Manuals/doc/changes/chap2.html#X803A9F0685295E01

Core gap code and databases have not changed since 4.8.8. The libgap for 4.8.8 that debian made should be identical for 4.8.10.

@nthiery
Copy link
Contributor

nthiery commented May 2, 2018

comment:16

Thanks François for the info.

The branch as is is not yet functional, as libgap needs to be the same version as gap.
Sebastian's libgap above is missing the prefixing; he will work on this tonight, and then I'll update this branch and rerun the tests.

@slel
Copy link
Member Author

slel commented Jul 24, 2018

comment:18

Replying to @nthiery:

The branch as is is not yet functional, as libgap needs to be the same version as gap.
Sebastian's libgap above is missing the prefixing; he will work on this tonight, and then I'll update this branch and rerun the tests.

Did the prefixing happen in the end? What remains to be done here?

@slel slel modified the milestones: sage-8.2, sage-8.4 Jul 24, 2018
@fchapoton
Copy link
Contributor

comment:19

can we close this one now ?

@fchapoton fchapoton removed this from the sage-8.4 milestone Jan 4, 2019
@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2019

Changed commit from a543971 to none

@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2019

Changed branch from u/nthiery/upgrade_to_gap_4_8_10 to none

@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2019

comment:20

I believe so.

@embray
Copy link
Contributor

embray commented Jan 7, 2019

comment:21

Superseded by #22626.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants