Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctest: Make Expression normalization work with symbolic powers #23861

Closed
rwst opened this issue Sep 14, 2017 · 12 comments
Closed

Doctest: Make Expression normalization work with symbolic powers #23861

rwst opened this issue Sep 14, 2017 · 12 comments

Comments

@rwst
Copy link

rwst commented Sep 14, 2017

Expression normalization only works with standard polynomials:

sage: (x^2 + x^(-2) - 2).normalize()
(x^4 - 2*x^2 + 1)/x^2

vs

sage: (x^(2*pi) + x^(-2*pi) - 2).normalize()
x^(2*pi) + x^(-2*pi) - 2

also (for different reasons):

sage: (e^2 + e^(-2) - 2).normalize()
e^2 + e^(-2) - 2

sage: (e^(2*pi) - e^(-2*pi)).normalize()
e^(2*pi) - e^(-2*pi)

This is necessary for being able to factor all symbolic expressions.

Depends on #23950

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 824a54a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23861

@rwst rwst added this to the sage-8.1 milestone Sep 14, 2017
@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented Sep 16, 2017

Upstream: Fixed upstream, in a later stable release.

@rwst
Copy link
Author

rwst commented Sep 16, 2017

Dependencies: pynac-0.7.12

@rwst
Copy link
Author

rwst commented Oct 1, 2017

Changed dependencies from pynac-0.7.12 to #23950

@rwst
Copy link
Author

rwst commented Oct 1, 2017

Changed upstream from Fixed upstream, in a later stable release. to none

@rwst
Copy link
Author

rwst commented Oct 24, 2017

Branch: u/rws/23861

@rwst
Copy link
Author

rwst commented Oct 24, 2017

Commit: 824a54a

@rwst
Copy link
Author

rwst commented Oct 24, 2017

New commits:

824a54a23861: Doctest fix for Expression normalization with symbolic powers

@rwst
Copy link
Author

rwst commented Oct 24, 2017

Author: Ralf Stephan

@rwst rwst changed the title Make Expression normalization work with symbolic powers Doctest: Make Expression normalization work with symbolic powers Oct 24, 2017
@tscrim
Copy link
Collaborator

tscrim commented Oct 25, 2017

comment:6

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Oct 25, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Oct 29, 2017

Changed branch from u/rws/23861 to 824a54a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants