Replace all pexpect-maxima calls in function/orthogonal-polys

[rwst]

Now that some functionality of specific orthogonal polys is handled by other than pexpect calls (?, see #17753) let's replace the unneeded calls completely.

There seems to be no reason to preserve the functionality func._maxima_init_evaled_(args) because the same can be had with maxima(func(args, hold=True)) which is also intuitive.

The ticket will also remove pexpect calls from OrthogonalPoly.

Depends on #22326
Depends on #22174

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 7a9eb46

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22325

[rwst]

Branch: u/rws/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys

[rwst]

New commits:

43a927b

22325: remove all _maxima_init_evaled_; move doctests to _init_

[rwst]

Dependencies: #22326

[rwst]

Commit: 43a927b

[rwst]

Author: Ralf Stephan

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

76ed92e	Merge branch 'develop' into t/22325/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys
648e498	22174: Interface expression conversion to gamma() and normalization
e82d2d2	Merge branch 'u/rws/interface_expression_conversion_to_gamma___and_normalization' of git://trac.sagemath.org/sage into t/22326/jacobi_p_polynomials_without_pexpect_maxima
445931a	22326: native symbolic jacobi_P
164d709	22326: fixes
e0bb9cf	Merge branch 'u/rws/jacobi_p_polynomials_without_pexpect_maxima' of git://trac.sagemath.org/sage into t/22325/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys
bf11e48	22325: finally remove _init()

[sagetrac-git]

Changed commit from 43a927b to bf11e48

[rwst]

Changed dependencies from #22326 to #22326, #22174

[tscrim]

comment:9

I am not sure about this change:

diff --git a/src/sage/functions/orthogonal_polys.py b/src/sage/functions/orthogonal_polys.py
index 1421a53..a6fe651 100644
--- a/src/sage/functions/orthogonal_polys.py
+++ b/src/sage/functions/orthogonal_polys.py
@@ -465,8 +412,6 @@ class OrthogonalFunction(BuiltinFunction):
             return self.eval_pari(*args, **kwds)
         elif algorithm == 'recursive':
             return self.eval_recursive(*args, **kwds)
-        elif algorithm == 'maxima':
-            return self._maxima_init_evaled_(*args, **kwds)
 
         return super(OrthogonalFunction,self).__call__(*args, **kwds)
 

as it seems like you are removing functionality to the user. Specifically, you either need to deprecate the algorithm='maxima' input or (IMO better) send it off to Maxima.

[rwst]

comment:10

Replying to @tscrim:

as it seems like you are removing functionality to the user. Specifically, you either need to deprecate the algorithm='maxima' input or (IMO better) send it off to Maxima.

Right, I intended delegating but did the wrong thing.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1c7b67e	22326: cosmetics
e04186d	Merge branch 'u/rws/jacobi_p_polynomials_without_pexpect_maxima' of git://trac.sagemath.org/sage into t/22325/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys
7a9eb46	22325: preserve algorithm='maxima', add doctests

[sagetrac-git]

Changed commit from bf11e48 to 7a9eb46

[rwst]

comment:12

Actually that never worked. Let's open a ticket for it.

[tscrim]

comment:13

Thanks. I agree; we can handle the algorithm issues on a followup.

[tscrim]

Reviewer: Travis Scrimshaw

[vbraun]

Changed branch from u/rws/replace_all_pexpect_maxima_calls_in_function_orthogonal_polys to 7a9eb46