-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QEPCAD: get rid of qepcad bits in src/bin/sage-location #21783
Comments
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
comment:3
Remind me, why are you pulling It just write one useful line for
If this is the path to singular, unless it is hardcoded to a location by default, it is in the path and therefore not very useful. |
Changed branch from u/mkoeppe/qepcad__location_of_default_qepcadrc_and_other_files to none |
Changed commit from |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: |
This comment has been minimized.
This comment has been minimized.
New commits:
|
Author: Matthias Koeppe |
comment:11
Let me see if I understand: this was in |
comment:12
Yes, that's right. |
comment:13
And to clarify, you're not changing the odd locations mentioned in the description. Is it worth modifying the description? The changes look good to me. |
Reviewer: John Palmieri |
comment:14
Thanks. I've pushed this to #31275 |
We move writing of the
default.qepcadrc
file fromsage-location
(where it is the last productive bit) to the installation file.CC: @kiwifb @embray @sagetrac-felixs @jdemeyer @fchapoton @jhpalmieri @dimpase
Component: packages: optional
Author: Matthias Koeppe
Branch/Commit:
3e40ee8
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/21783
The text was updated successfully, but these errors were encountered: