Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QEPCAD: get rid of qepcad bits in src/bin/sage-location #21783

Closed
mkoeppe opened this issue Oct 30, 2016 · 21 comments
Closed

QEPCAD: get rid of qepcad bits in src/bin/sage-location #21783

mkoeppe opened this issue Oct 30, 2016 · 21 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 30, 2016

We move writing of the default.qepcadrc file from sage-location (where it is the last productive bit) to the installation file.

CC: @kiwifb @embray @sagetrac-felixs @jdemeyer @fchapoton @jhpalmieri @dimpase

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: 3e40ee8

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/21783

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 30, 2016

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

b090a6dinitialize SAGE_ETC (from environ) in sage-location before use

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2016

Commit: b090a6d

@kiwifb
Copy link
Member

kiwifb commented Oct 30, 2016

comment:3

Remind me, why are you pulling SAGE_ETC from sage.misc.misc rather than sage.env? In fact I would like to know if this file is needed at all.

It just write one useful line for qepcadrc

SINGULAR $expanded_path_to_SAGE_LOCAL/bin

If this is the path to singular, unless it is hardcoded to a location by default, it is in the path and therefore not very useful.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2020

Changed branch from u/mkoeppe/qepcad__location_of_default_qepcadrc_and_other_files to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2020

Changed commit from b090a6d to none

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title QEPCAD: Location of default.qepcadrc and other files QEPCAD: Location of default.qepcadrc and other files, get rid of qepcad bits in src/bin/sage-location Jul 16, 2020
@mkoeppe mkoeppe added this to the sage-9.2 milestone Jul 16, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 13, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title QEPCAD: Location of default.qepcadrc and other files, get rid of qepcad bits in src/bin/sage-location QEPCAD: Location of default.qepcadrc and other files, get rid of qepcad bits in src/bin/sage-location, add spkg-configure Oct 23, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 20, 2021

Commit: 3e40ee8

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 20, 2021

New commits:

3e40ee8build/pkgs/qepcad/spkg-install.in: Generate default.qepcadrc instead of doing this in src/bin/sage-location

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 20, 2021

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title QEPCAD: Location of default.qepcadrc and other files, get rid of qepcad bits in src/bin/sage-location, add spkg-configure QEPCAD: get rid of qepcad bits in src/bin/sage-location Jan 20, 2021
@jhpalmieri
Copy link
Member

comment:11

Let me see if I understand: this was in sage-location because it needed to hardcode the value of SAGE_LOCAL in default.qepcadrc, so if that location changed, default.qepcadrc needed to be rewritten. Is that right? If so, it makes sense to move it to the spkg-install.in script.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 21, 2021

comment:12

Yes, that's right.

@jhpalmieri
Copy link
Member

comment:13

And to clarify, you're not changing the odd locations mentioned in the description. Is it worth modifying the description? The changes look good to me.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 21, 2021

comment:14

Thanks. I've pushed this to #31275

@mkoeppe

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants