Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acsch(float) returns complex #20818

Closed
rwst opened this issue Jun 12, 2016 · 11 comments
Closed

acsch(float) returns complex #20818

rwst opened this issue Jun 12, 2016 · 11 comments

Comments

@rwst
Copy link

rwst commented Jun 12, 2016

sage: arccsch(float(0.1))
(2.99822295029797+0j)

should be

2.99822295029797

8-year old bug, triggered by recent Pynac changes

Component: symbolics

Author: Ralf Stephan

Branch: 4df530d

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/20818

@rwst rwst added this to the sage-7.3 milestone Jun 12, 2016
@rwst
Copy link
Author

rwst commented Jun 12, 2016

Branch: u/rws/acsch_float__returns_complex

@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented Jun 12, 2016

New commits:

4df530d20818: back conversion in py_asinh incomplete

@rwst
Copy link
Author

rwst commented Jun 12, 2016

Commit: 4df530d

@rwst
Copy link
Author

rwst commented Jun 12, 2016

Author: Ralf Stephan

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:3

ok, looks good to me

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Jun 12, 2016

comment:4

Ralf, I'm curious as to how you recognized the bug. Is there a previous Trac ticket?

@vbraun
Copy link
Member

vbraun commented Jun 12, 2016

Changed branch from u/rws/acsch_float__returns_complex to 4df530d

@rwst
Copy link
Author

rwst commented Jun 13, 2016

comment:6

Replying to @paulmasson:

Ralf, I'm curious as to how you recognized the bug. Is there a previous Trac ticket?

After Volker gave me a function argument that showed the problem I traced what Pynac was doing. It called the fixed function and then it was obvious. How I know that this is 8 year old? You can use git blame to see when a specific line was changed.

@rwst
Copy link
Author

rwst commented Jun 13, 2016

Changed commit from 4df530d to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants