Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cython package to 0.9.6.11 #1801

Closed
robertwb opened this issue Jan 17, 2008 · 4 comments
Closed

Update cython package to 0.9.6.11 #1801

robertwb opened this issue Jan 17, 2008 · 4 comments

Comments

@robertwb
Copy link
Contributor

http://sage.math.washington.edu/home/robertwb/cython/

everything passes with sage -testall

Main improvements:

  • PyObject_CallObject -> PyObject_Call (up to 5% speed increase for python function calls)
  • More correct .pyx file annotation (the click-able yellow lines)
  • Better support for non-GC objects
  • Optimized tp_new/dealloc/traverse/clear slots (similar to our first attempt to speed up integers, but globally)
  • Re-enable pre-import (e.g. from sage.all import *)
  • __cinit__ (a.k.a __new__) can have optimized signature __new__(self) regardless of __init__ params
  • correct overflow error handling for all c int types (before just long was handled correctly)
  • (optional) for i in range(...) -> for i from ... conversion
  • several minor bug fixes
  • cleaned up spkg

Component: packages: standard

Issue created by migration from https://trac.sagemath.org/ticket/1801

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 18, 2008

comment:2

With Sage 2.10 [more or less final] I get:

gcc -fno-strict-aliasing -DNDEBUG -g -O3 -Wall -Wstrict-prototypes -fPIC -I/scratch/mabshoff/release-cycle/sage-2.10.alpha4/local//include -I/scratch/mabshoff/release-cycle/sage-2.10.alpha4/local//include/csage -I/scratch/mabshoff/release-cycle/sage-2.10.alpha4/devel//sage/sage/ext -I/scratch/mabshoff/release-cycle/sage-2.10.alpha4/local/include/python2.5 -c sage/libs/pari/gen.c -o build/temp.linux-x86_64-2.5/sage/libs/pari/gen.o -w
sage/libs/pari/gen.c: In function ‘__pyx_tp_clear_4sage_4libs_4pari_3gen_PariInstance’:
sage/libs/pari/gen.c:33063: error: invalid lvalue in assignment
sage/libs/pari/gen.c:33066: error: invalid lvalue in assignment
sage/libs/pari/gen.c:33069: error: invalid lvalue in assignment
error: command 'gcc' failed with exit status 1
sage: There was an error installing modified sage library code.

This corresponds to:

static int __pyx_tp_clear_4sage_4libs_4pari_3gen_PariInstance(PyObject *o) {
  struct __pyx_obj_4sage_4libs_4pari_3gen_PariInstance *p = (struct __pyx_obj_4sage_4libs_4pari_3gen_PariInstance *)o;
  PyObject* tmp;
  if (__pyx_ptype_4sage_9structure_11parent_base_ParentWithBase->tp_clear) {
    __pyx_ptype_4sage_9structure_11parent_base_ParentWithBase->tp_clear(o);
  }
  tmp = ((PyObject*)p->ZERO);
  ((PyObject*)p->ZERO) = Py_None; Py_INCREF(Py_None); [line 33063]
  Py_XDECREF(tmp);
  tmp = ((PyObject*)p->ONE);
  ((PyObject*)p->ONE) = Py_None; Py_INCREF(Py_None);
  Py_XDECREF(tmp);
  tmp = ((PyObject*)p->TWO);
  ((PyObject*)p->TWO) = Py_None; Py_INCREF(Py_None);
  Py_XDECREF(tmp);
  return 0;
}

Cheers,

Michael

@robertwb
Copy link
Contributor Author

comment:3

New Cython package up at the same url which should resolve this issue.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 18, 2008

comment:4

I can confirm that the latest cython.spkg completes a sage -ba without issues.

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 19, 2008

comment:5

Merged cython-0.9.6.11b.spkg in Sage 2.10.1.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jan 19, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant