Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more load/save bugs #17654

Closed
jdemeyer opened this issue Jan 20, 2015 · 17 comments
Closed

Fix more load/save bugs #17654

jdemeyer opened this issue Jan 20, 2015 · 17 comments

Comments

@jdemeyer
Copy link

  1. Remove all documentation about load filename, it should be load("filename").
  2. src.sage.repl.load calls eval(!) on the filename, deprecate that behaviour.
  3. The optional - internet tests in src/sage/repl/load.py are broken since Move preparsing, loading and attaching to src/sage/repl #17396.
  4. Move loading of Fortran files to src/sage/repl/load.py.

Depends on #17460

Component: misc

Author: Jeroen Demeyer

Branch: 1e8ee98

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/17654

@jdemeyer jdemeyer added this to the sage-6.5 milestone Jan 20, 2015
@jdemeyer
Copy link
Author

Dependencies: #17460

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/17654

@jdemeyer
Copy link
Author

Commit: 1e8ee98

@jdemeyer
Copy link
Author

New commits:

d12c094Deprecate moved imports from sage.misc.misc
1e8ee98Fix more load/save bugs

@mezzarobba
Copy link
Member

comment:9

LGTM, but there appears to be a minor merge conflict with #17533.

@jdemeyer
Copy link
Author

Reviewer: Marc Mezzarobba

@jdemeyer
Copy link
Author

comment:10

Replying to @mezzarobba:

there appears to be a minor merge conflict with #17533.

Fixed now.

@jdemeyer
Copy link
Author

comment:12

Thanks!

@vbraun
Copy link
Member

vbraun commented Feb 17, 2015

Changed branch from u/jdemeyer/ticket/17654 to 1e8ee98

@gvol
Copy link

gvol commented Mar 25, 2015

Changed commit from 1e8ee98 to none

@gvol
Copy link

gvol commented Mar 25, 2015

comment:14

I'm seeing the warning when I use

sage: %runfile '/var/folders/d3/yxwv5yn5715fk31lq36lnk780000gn/T/sage24271vpp.sage' # loading region...
/Users/iandrus/vcs/sage/src/bin/sage-ipython:1: DeprecationWarning: using unevaluated expressions as argument to load() is dangerous and deprecated
See http://trac.sagemath.org/17654 for details.
  #!/usr/bin/env python

Is that expected? And I should change it to

load('/var/folders/d3/yxwv5yn5715fk31lq36lnk780000gn/T/sage24271vpp.sage')

@jdemeyer
Copy link
Author

comment:15

Remove the quotes:

sage: %runfile /var/folders/d3/yxwv5yn5715fk31lq36lnk780000gn/T/sage24271vpp.sage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants