Restore displaying animations in notebook

[gagern]

#12827 broke display of animations, and while #16608 restored that functionality for Animation.show(), it remains broken for methods Animation.gif() and Animation.ffmpeg(). Based on #15515, a more complete fix is possible.

Depends on #15515
Depends on #16608

Component: graphics

Keywords: notebook, animate

Author: Martin von Gagern

Branch/Commit: 2c5f58b

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/16645

[gagern]

Branch: u/gagern/ticket/16645

[gagern]

Commit: 9f30e94

[gagern]

New commits:

58b9c46	minimal fix to restore functionality
16cbd2d	Merge branch 'develop' into ticket/16533-stopgap
b3e656b	graphics_filename: return a tmp_filename() if not in EMBEDDED_MODE
69b285d	Restore possibly positional arguments.
e3c5542	Merge branch ticket/15515 into ticket/16608 to create ticket/16645.
9f30e94	Always use graphics_filename instead of tmp_filename.

[gagern]

comment:3

Note that only 9f30e94 is new for this ticket here, all the other commits listed above are parts of some already closed tickets and should end up in the develop branch pretty soon. So it is enough to review just that single commit.

[sagetrac-git]

Changed commit from 9f30e94 to bb7307f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

bb7307f

Prevent doctest from leaking file into current working directory.

[gagern]

comment:5

These are the changes that need reviewing in this ticket here.

[vbraun]

comment:6

tmp_filename is already a global in Sage, you don't need

sage: f = sage.misc.temporary_file.tmp_filename(ext='.png')

in doctests.`

[vbraun]

Reviewer: Volker Braun

[vbraun]

comment:8

lgtm

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

2c5f58b

Avoid unneccessary qualification of tmp_filename in doctests.

[sagetrac-git]

Changed commit from bb7307f to 2c5f58b

[gagern]

comment:10

Replying to @vbraun:

tmp_filename is already a global in Sage […]

Thanks for the review, and for pointing this out. I did copy and paste that from 745a3bb from #12827, and addressed both instances now.

[vbraun]

Changed branch from u/gagern/ticket/16645 to 2c5f58b