Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase number of matches to "tree" in sagedoc.py doctest #14433

Closed
jdemeyer opened this issue Apr 10, 2013 · 7 comments
Closed

Increase number of matches to "tree" in sagedoc.py doctest #14433

jdemeyer opened this issue Apr 10, 2013 · 7 comments

Comments

@jdemeyer
Copy link

Depends on #8703

Dependencies: merge with #8703

Component: doctest coverage

Author: Jeroen Demeyer

Reviewer: Travis Scrimshaw

Merged: sage-5.10.beta0

Issue created by migration from https://trac.sagemath.org/ticket/14433

@jdemeyer
Copy link
Author

comment:1

Attachment: 14433_search_doc.patch.gz

@jdemeyer
Copy link
Author

Dependencies: merge with #8703

@tscrim
Copy link
Collaborator

tscrim commented Apr 15, 2013

comment:3

With #8703, I got this on 5.9.beta5:

sage -t --long misc/sagedoc.py
**********************************************************************
File "misc/sagedoc.py", line 1039, in sage.misc.sagedoc.?
Failed example:
    len(search_doc('tree', interact=False).splitlines()) > 4000  # long time
Expected:
    True
Got:
    False

@tscrim
Copy link
Collaborator

tscrim commented Apr 15, 2013

Reviewer: Travis Scrimshaw

@jdemeyer
Copy link
Author

comment:4

Are you sure you remembered to run make doc after applying the patch?

@tscrim
Copy link
Collaborator

tscrim commented Apr 15, 2013

comment:5

No I didn't. I ran it and it passed all tests.

@jdemeyer
Copy link
Author

Merged: sage-5.10.beta0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants