Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenericGraph.is_circulant() test #14250

Closed
nathanncohen mannequin opened this issue Mar 10, 2013 · 9 comments
Closed

GenericGraph.is_circulant() test #14250

nathanncohen mannequin opened this issue Mar 10, 2013 · 9 comments
Assignees
@jasongrout @rlmill @nathanncohen
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-5.9

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Mar 10, 2013

Tests whether a graph is a circulant graph (or digraph). Very good to have around when trying to find nice drawings of vertex-transitive graphs :-)

Nathann

Depends on #14251

Component: graph theory

Author: Nathann Cohen

Reviewer: Frédéric Chapoton

Merged: sage-5.9.beta1

Issue created by migration from https://trac.sagemath.org/ticket/14250
@nathanncohen nathanncohen mannequin added this to the sage-5.9 milestone Mar 10, 2013
@nathanncohen nathanncohen mannequin added the s: needs review label Mar 10, 2013
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 10, 2013

Dependencies: #14251

@fchapoton
Copy link
Contributor

comment:3

Hello,

  • there is a typo in the OUTPUT
returns ``(False, None`` or
  • maybe add a link to the wikipedia article :wikipedia:Circulant graph ?

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 14, 2013

Attachment: trac_14250.patch.gz

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 14, 2013

comment:4

Done !

Nathann

@fchapoton
Copy link
Contributor

Attachment: trac_14250-review-fc.patch.gz

@fchapoton
Copy link
Contributor

comment:5

Hello,

once the bot turns green again, and if you are happy with my review patch, you can set a positive review,

cheers,

Frederic

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 15, 2013

Reviewer: Frédéric Chapoton

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 15, 2013

comment:6

Green light from the bot, and thaaaaaaaaank you for your modifications. Looks like I still sound like a foreigner when I talk about groups :-)

Nathann

@jdemeyer
Copy link

Merged: sage-5.9.beta1

@nathanncohen nathanncohen mannequin mentioned this issue Jan 20, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasongrout jasongrout

@rlmill rlmill

@nathanncohen nathanncohen

Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-5.9
Development

No branches or pull requests
3 participants
@jasongrout @jdemeyer @fchapoton