Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning doesn't properly copy the _static doc directory #14245

Closed
hivert opened this issue Mar 8, 2013 · 15 comments
Closed

Cloning doesn't properly copy the _static doc directory #14245

hivert opened this issue Mar 8, 2013 · 15 comments

Comments

@hivert
Copy link

hivert commented Mar 8, 2013

When cloning Sage (eg: for combinat), the doc is copied but not properly:
Before the clone in doc/output/html/en/reference/numerical there is a symlink _static to ../_static. After the clone, it is an empty directory. Also the directories such as

doc/en/reference/algebras/sage
doc/en/reference/calculus/sage
...

are note copied at all.

CC: @jhpalmieri @nexttime @nilesjohnson @hivert @mguaypaq @mwhansen

Component: documentation

Keywords: _static clone

Author: John Palmieri

Reviewer: Florent Hivert

Merged: sage-5.8.rc0

Issue created by migration from https://trac.sagemath.org/ticket/14245

@kcrisman

This comment has been minimized.

@jhpalmieri
Copy link
Member

Author: John Palmieri

@jhpalmieri
Copy link
Member

Changed keywords from _static to _static clone

@jhpalmieri
Copy link
Member

comment:3

I think this patch will fix the problem. I also think that the sage-clone script could use some attention in general, but now is not the time.

@hivert
Copy link
Author

hivert commented Mar 10, 2013

comment:4

I'm testing this patch currently but I think I'll give it positive review.

Florent

@hivert
Copy link
Author

hivert commented Mar 10, 2013

comment:5

Hum ! The problem of copying the _static directory is fixed but there is another one: There is a lot of

WARNING: toctree contains reference to nonexisting document '...'

and indeed the doc is empty. This should also be fixed. I'm investigating for the cause.

@hivert
Copy link
Author

hivert commented Mar 10, 2013

comment:6

Ok ! I think I got it. During cloning the directories such as

doc/en/reference/algebras/sage
doc/en/reference/calculus/sage
...

are note copied. Sorry I have to go to bed... I'll fix this tomorrow if no one beats me.

@jhpalmieri
Copy link
Member

comment:7

Sorry, I missed that. Here's a better attempt.

@jhpalmieri
Copy link
Member

scripts repo

@hivert
Copy link
Author

hivert commented Mar 10, 2013

comment:8

Attachment: trac_14245_clone.patch.gz

Looks good to me. Thanks !

@hivert

This comment has been minimized.

@hivert
Copy link
Author

hivert commented Mar 10, 2013

Reviewer: Florent Hivert

@jhpalmieri
Copy link
Member

comment:9

I wonder if we should (on another ticket, like #13245) also disable docbuilding altogether when cloning...

@nexttime
Copy link
Mannequin

nexttime mannequin commented Mar 11, 2013

comment:10

Replying to @jhpalmieri:

I wonder if we should (on another ticket, like #13245) also disable docbuilding altogether when cloning...

+N

@jdemeyer jdemeyer modified the milestones: sage-5.9, sage-5.8 Mar 11, 2013
@jdemeyer
Copy link

Merged: sage-5.8.rc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants