-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quickstarts from PREP workshops to standard documentation #13381
Comments
Dependencies: #13260 |
Based on 5.3.beta1 |
This comment has been minimized.
This comment has been minimized.
comment:2
Attachment: trac_13381-quickstarts.patch.gz Ready for review. Patchbot, apply trac_13381-quickstarts.patch. |
This comment has been minimized.
This comment has been minimized.
comment:3
Here is a referee patch. If it's okay with you, then one item remains to be addressed: in
Other comments (I think most of my changes are self-explanatory):
The use of upper case in the file names here (and in the parent directory) doesn't follow the same pattern as elsewhere in the Sage library. This is certainly not a big deal, but it looks a little strange to me. |
Attachment: trac_13381-ref.patch.gz referee patch; apply on top of other one |
comment:4
regarding left vs. right: I guess I always think that the way I do it naturally is the "right" (correct) way to do it :). That helps me remember that the normal linear algebra way (column vectors, A*x) is the "right" way. Not that I'm biased or anything :). |
comment:5
John, did you review this positively, or is there still more to do? |
comment:6
In my comment above, I said that "one item remains to be addressed". This is still true. |
comment:7
I think he was at least thinking the |
comment:8
The heading could be changed to "Converting to IEEE floating point binary format"---does that make things clearer? The rest of the paragraph in question explains that the first step in IEEE conversion is normalizing the number so that it is a number between 1 and 2 (multiplied by an appropriate power of 2). |
comment:9
Or how about this rewording of the paragraph:
Is that better? |
Reviewer: John Palmieri, Jason Grout |
comment:10
That seems reasonable. Actually, making the section heading "Converting to floating point binary (IEEE format)" would be the best compromise on the heading title as well. |
comment:11
These all look like good suggestions to me. |
Apply on top of others |
This comment has been minimized.
This comment has been minimized.
Changed dependencies from #13260 to none |
comment:12
Attachment: trac_13381-ieee.patch.gz Okay, I've finished this off by just implementing this. John was okay with this, and all I did was put what Jason suggested. Yay! |
comment:13
There are obvious doctest failures, why did this ever get positive review? While you're at it, you should also use the new-style doctest continuations
instead of
|
comment:14
Because the only previous complaints were about non-doctest issues. Patchbot is very flaky, in my opinion, and often fails for trivial reasons. Interestingly, at least one of these failures indicates a regression in Sage. The rest are pretty easy to fix, I'll do this later today along with the new-style continuations. |
comment:15
I also changed to new continuations in the main prep stuff. Very annoying. Some of the changes are pretty recent as well. There are two remaining issues, I think.
This is because scipy now assumes a Sage Integer is not a scalar. I'm not sure whether this is an upstream bug or not. Then there is this strange regression in plotting power series.
If I just do the polynomial, it's fine, so I can fix the test. Interestingly, I get a different error with the standard syntax:
|
comment:16
I think I have discovered a really nasty bug with new-style line continuations. I cannot get live documentation to work with it. So I am not going to do this. For some reason the new such doctests don't seem to be in the live documentation (probably in underscore methods, and not a lot of them), so that's why it hasn't been noticed. This is as of 5.11.beta1. |
Changed reviewer from John Palmieri, Jason Grout to John Palmieri, Jason Grout, Jeroen Demeyer |
This comment has been minimized.
This comment has been minimized.
comment:17
Patchbot, apply trac_13381-quickstarts.patch, trac_13381-ref.patch, and trac_13381-fixtests.patch Doctests are now fixed, I fixed some broken links (no thanks to the reorganization of the reference manual!), and of course the IEEE business. All tests pass. There is nothing substantive changed, though, and I think jeroen's comments suffice. |
comment:18
Still some issues in live documentation, one moment... |
Apply last |
comment:19
Attachment: trac_13381-fixtests.patch.gz All set!! Patchbot, apply trac_13381-quickstarts.patch, trac_13381-ref.patch, and trac_13381-fixtests.patch |
Merged: sage-5.11.rc0 |
This ticket is to add the quickstart tutorials, originally at #13260. It was split off from that ticket for convenience.
Apply attachment: trac_13381-quickstarts.patch, attachment: trac_13381-ref.patch, and attachment: trac_13381-fixtests.patch.
Depends on #5457
Depends on #9005
Depends on #14014
CC: @jasongrout @rbeezer @dandrake @wdjoyner @sagetrac-mhampton @benjaminfjones @wypong @dcernst @sagetrac-travis @novoselt @jhpalmieri
Component: documentation
Author: Karl-Dieter Crisman
Reviewer: John Palmieri, Jason Grout, Jeroen Demeyer
Merged: sage-5.11.rc0
Issue created by migration from https://trac.sagemath.org/ticket/13381
The text was updated successfully, but these errors were encountered: