Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cremona's table of elliptic curves for Sage #12308

Closed
ohanar opened this issue Jan 14, 2012 · 15 comments
Closed

Update Cremona's table of elliptic curves for Sage #12308

ohanar opened this issue Jan 14, 2012 · 15 comments

Comments

@ohanar
Copy link
Member

ohanar commented Jan 14, 2012

Cremona's database has been updated twice since #11587, the purpose of this ticket is to update the optional spkg to the current version.

I've posted the a new spkg at http://wstein.org/home/ohanar/cremona-database/database_cremona_ellcurve-20120113.spkg.

Depends on #11587

CC: @JohnCremona

Component: elliptic curves

Author: R. Andrew Ohana

Reviewer: John Cremona

Merged: sage-4.8

Issue created by migration from https://trac.sagemath.org/ticket/12308

@JohnCremona
Copy link
Member

comment:2

Positive review -- the new spkg installs fine on 4.8.alpha5 and then all tests in sage/schemes/elliptic_curve pass. Thanks, Andrew!

@ohanar
Copy link
Member Author

ohanar commented Jan 14, 2012

Reviewer: John Cremona

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer modified the milestones: sage-4.8, sage-5.0 Jan 14, 2012
@jdemeyer
Copy link

comment:5

Sorry, but I really don't want to add anything more to sage-4.8 (apart to fix serious bugs).

@JohnCremona
Copy link
Member

comment:6

Replying to @jdemeyer:

Sorry, but I really don't want to add anything more to sage-4.8 (apart to fix serious bugs).

Understood -- but it's only an optional spkg. Anyway, release manager gets to have the last word...

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

comment:8

Optional spkgs aren't really versioned. They don't follow Sage releases, they are just posted all together. Which means that it doesn't matter when this ticket is closed.

@jdemeyer
Copy link

Work Issues: HTTP 404

@jdemeyer
Copy link

comment:9
Not Found

The requested URL /home/ohanar/cremona-database/database_cremona_ellcurve-20120113.skpg. was not found on this server.
Apache/2.2.8 (Ubuntu) DAV/2 SVN/1.5.1 mod_python/3.3.1 Python/2.5.2 mod_ssl/2.2.8 OpenSSL/0.9.8g mod_wsgi/2.0 Server at boxen.math.washington.edu Port 80

@ohanar
Copy link
Member Author

ohanar commented Jan 15, 2012

comment:10

Replying to @jdemeyer:

Optional spkgs aren't really versioned. They don't follow Sage releases, they are just posted all together. Which means that it doesn't matter when this ticket is closed.

Before #11587 there were a few places within the sage library which had hard coded the version of the database.

@ohanar

This comment has been minimized.

@ohanar
Copy link
Member Author

ohanar commented Jan 15, 2012

Changed work issues from HTTP 404 to none

@JohnCremona
Copy link
Member

comment:11

I re-tested this (I was able to find the correct spkg the first time, BTW). It applied fine to 4.8.rc0 and all relevant tests pass.

sage: CDB=CremonaDatabase()              
sage: CDB.number_of_curves()         
1406789
sage: CDB.number_of_isogeny_classes()
965348
sage: CDB.conductor_range()
(1, 220000)

Whenever 4.8 is released this spkg needs to be put where the other oprional spgs are.
I really really do not see why this has to wait until 5.0 since it has no effect at all on the Sage library....

@jdemeyer jdemeyer removed this from the sage-5.0 milestone Jan 18, 2012
@jdemeyer jdemeyer added this to the sage-4.8 milestone Jan 18, 2012
@JohnCremona
Copy link
Member

comment:13

Replying to @jdemeyer:
:) :) :)

@jdemeyer
Copy link

Merged: sage-4.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants