-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cremona's table of elliptic curves for Sage #12308
Comments
comment:2
Positive review -- the new spkg installs fine on 4.8.alpha5 and then all tests in sage/schemes/elliptic_curve pass. Thanks, Andrew! |
Reviewer: John Cremona |
This comment has been minimized.
This comment has been minimized.
comment:5
Sorry, but I really don't want to add anything more to sage-4.8 (apart to fix serious bugs). |
comment:6
Replying to @jdemeyer:
Understood -- but it's only an optional spkg. Anyway, release manager gets to have the last word... |
This comment has been minimized.
This comment has been minimized.
comment:8
Optional spkgs aren't really versioned. They don't follow Sage releases, they are just posted all together. Which means that it doesn't matter when this ticket is closed. |
Work Issues: HTTP 404 |
comment:9
|
comment:10
Replying to @jdemeyer:
Before #11587 there were a few places within the sage library which had hard coded the version of the database. |
This comment has been minimized.
This comment has been minimized.
Changed work issues from HTTP 404 to none |
comment:11
I re-tested this (I was able to find the correct spkg the first time, BTW). It applied fine to 4.8.rc0 and all relevant tests pass.
Whenever 4.8 is released this spkg needs to be put where the other oprional spgs are. |
comment:13
Replying to @jdemeyer: |
Merged: sage-4.8 |
Cremona's database has been updated twice since #11587, the purpose of this ticket is to update the optional spkg to the current version.
I've posted the a new spkg at http://wstein.org/home/ohanar/cremona-database/database_cremona_ellcurve-20120113.spkg.
Depends on #11587
CC: @JohnCremona
Component: elliptic curves
Author: R. Andrew Ohana
Reviewer: John Cremona
Merged: sage-4.8
Issue created by migration from https://trac.sagemath.org/ticket/12308
The text was updated successfully, but these errors were encountered: