Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade setuptools to 0.6c11 #10361

Closed
sagetrac-Koen mannequin opened this issue Dec 1, 2010 · 29 comments
Closed

upgrade setuptools to 0.6c11 #10361

sagetrac-Koen mannequin opened this issue Dec 1, 2010 · 29 comments

Comments

@sagetrac-Koen
Copy link
Mannequin

sagetrac-Koen mannequin commented Dec 1, 2010

The current setuptools version in Sage is 0.6c9. However, in the 0.6c11 update, there's an important change:

 * Fixes for various dependency management problems such as looping builds, 
   re-downloading packages already present on sys.path (but not in a registered
   "site" directory), and semi-randomly preferring local "-f" packages over
   local installed packages

The problem in the PyCUDA package with a corrupted setuptools ( #10010 ) after installing distribute is caused due to this outdated setuptools version.

The package is really simple (like the current 0.6c9 package), because it has no patches compared to the vanilla setuptools from http://pypi.python.org/pypi/setuptools . Therefore, I just copied in the new source and that was it.

Upstream: Fixed upstream, in a later stable release.

CC: @jaapspies

Component: packages: standard

Keywords: distribute

Reviewer: Mariah Lenox

Issue created by migration from https://trac.sagemath.org/ticket/10361

@sagetrac-Koen sagetrac-Koen mannequin added this to the sage-4.6.1 milestone Dec 1, 2010
@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

comment:2

(Almost) regardless of its size, never attach a binary file on trac... ;-)

Instead, put a link to it on the ticket, and perhaps attach an spkg diff or Mercurial patch to the ticket for reference / review.

If you don't have a sagemath account (or some other place to upload it), you can use http://code.google.com/p/spkg-upload/ .

I think I've already made such an spkg IIRC, with further clean-up a while ago. Let me see...

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

Author: Keshav Kini

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

Changed keywords from none to distribute

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

comment:3

Replying to @nexttime:

I think I've already made such an spkg IIRC, with further clean-up a while ago. Let me see...

Ah, no. I looked at the 0.6c11, but did not make a new spkg, but only patched the 0.6c9 with some "debug" code, adding more messages regarding the handling of .pth files with which we had trouble.

I'll take a look at your spkg.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

Attachment: trac_10361-fix_spkg-install-spkg.patch.gz

SPKG patch. Adds error checking etc.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

Changed author from Keshav Kini to Koen van de Sande, Leif Leonhardy

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

comment:4

I've attached a patch to spkg-install.

Koen: You haven't updated SPKG.txt.

(I haven't either.) Can you do that and provide an updated spkg somewhere else (with also my patch applied)?

I'll then ask someone powerful to remove the spkg attached to the ticket.

(P.S.: Sorry, confused your name...)

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

comment:5

Besides applying the patch, you apparently also have to

chmod +x spkg-install

again.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

comment:6

Also, please delete Michael Abshoff from the spkg maintainer list in SPKG.txt, and

rm setuptools-0.6c11.p0/src/setuptools/gui.exe
rm setuptools-0.6c11.p0/src/setuptools/cli.exe

A comment on this should go into the (not yet existing) Special Update/Build Instructions section.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

comment:7

CC'ing the remaining spkg maintainer...

@sagetrac-Koen
Copy link
Mannequin Author

sagetrac-Koen mannequin commented Dec 15, 2010

comment:8

Here's the updated package:
http://code.google.com/p/spkg-upload/downloads/detail?name=setuptools-0.6c11.p0.spkg
Also, I'm under the impression that SPKG.txt/spkg-install are under version control somewhere. Note that I modified the files and haven't committed them anywhere.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

comment:9

Replying to @sagetrac-Koen:

Also, I'm under the impression that SPKG.txt/spkg-install are under version control somewhere. Note that I modified the files and haven't committed them anywhere.

Somewhere? :)

Every spkg has its Mercurial repository (.hg), which contains the Sage part of the spkg, but not the upstream code (src/, which is in .hgignore).

So you just have to hg commit and provide a commit message, starting with the ticket number (#10361), and a brief (one-line) description. (You can optionally in addition provide a longer description, e.g. a copy of your Changelog entry, below that first and a blank line.)

You may have to create/edit your ~/.hgrc first, such that Mercurial adds the proper name and e-mail address.

I'll see how you applied my patch without using Mercurial(?)... You should have perhaps first updated SPKG.txt, committed your changes, and then hg import /path/to/my/patch.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

comment:10

P.S.:

In case you want to update your spkg at spkg-upload, first delete the old one, then you can (re-)upload a new one with the same name.

We usually provide the md5sum of an spkg along with the (raw) download link on the ticket, (also) to avoid confusion with previous versions.

@sagetrac-Koen
Copy link
Mannequin Author

sagetrac-Koen mannequin commented Dec 15, 2010

comment:11

OK, this time by using version control (I didn't realize the complete repository is in the spkg, I thought there was a centralized repository somewhere).

http://spkg-upload.googlecode.com/files/setuptools-0.6c11.p0.spkg
SHA1 Checksum: bd8a3be6200f66163ab51ec2c08b9a10cb46fc7f

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

comment:12

Replying to @sagetrac-Koen:

OK, this time by using version control (I didn't realize the complete repository is in the spkg, I thought there was a centralized repository somewhere).

http://spkg-upload.googlecode.com/files/setuptools-0.6c11.p0.spkg
SHA1 Checksum: bd8a3be6200f66163ab51ec2c08b9a10cb46fc7f

Ok, the .exe files are back, but they're quite small (8 KB each).

The changelog entry should name the whole spkg (base)name (i.e. setuptools-0.6c11**.p0**), and it's convenient to also have the ticket number in the changelog, but I don't mind.

I've tested it with both Sage 4.6.1.alpha2 and alpha3, also by reinstalling SageNB (which uses setuptools).

So if you are ok with my changes, too, we have a positive review.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Dec 15, 2010

Reviewer: Leif Leonhardy

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Dec 15, 2010

comment:13

I'm responding to Leif's email for the .spkg to be deleted, so I've done it.

Note, that .spkg's should never be attached to trac. The system is not set up to handle large files, which .spkg's generally are. (In fact, I've lost count the number of times trac stops working because a file system is full)

Please instead put them on a server of some sort and provide a link with and ideally state the md5 checksum too.

Note William will give any Sage developer an account on the *.math.washington.edu network. Since your home directory is then publicly readable, just stick .spkg's in your home directory, or probably more logically make a sub-directory and stick them there.

Here's my directory - I should clean some of the older ones out!

http://boxen.math.washington.edu/home/kirkby/patches/

Dave

@sagetrac-Koen
Copy link
Mannequin Author

sagetrac-Koen mannequin commented Dec 16, 2010

comment:14

I'm ok with the changes by Leif, so we're now at positive review.

@sagetrac-Koen
Copy link
Mannequin Author

sagetrac-Koen mannequin commented Dec 16, 2010

Changed reviewer from Leif Leonhardy to Leif Leonhardy, Koen van de Sande

@jdemeyer
Copy link

Merged: sage-4.6.2.alpha1

@jdemeyer
Copy link

comment:17

Could this cause twisted to fail to install on bsd.math (OS X)?

@jdemeyer
Copy link

Changed merged from sage-4.6.2.alpha1 to none

@jdemeyer
Copy link

Work Issues: breaks twisted on OS X??

@jdemeyer
Copy link

Changed work issues from breaks twisted on OS X?? to breaks twisted on OS X

@jdemeyer
Copy link

comment:20

Confirmed that this new spkg actually breaks building twisted on bsd.math.

@jdemeyer
Copy link

jdemeyer commented Jun 7, 2011

Changed reviewer from Leif Leonhardy, Koen van de Sande to Mariah Lenox

@jdemeyer
Copy link

jdemeyer commented Jun 7, 2011

comment:21

See #11363 instead.

@jdemeyer
Copy link

jdemeyer commented Jun 7, 2011

Changed author from Koen van de Sande, Leif Leonhardy to none

@jdemeyer
Copy link

jdemeyer commented Jun 7, 2011

Changed work issues from breaks twisted on OS X to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant