Disable parallel "make install" in Python spkg

[jdemeyer]

The python spkg should not use parallel "make install". This is claimed to be fixed in the spkg, but it actually isn't done properly. There are some comments in spkg-install about how to fix it.

Also, the python library should be installed with writable permission 0755, instead of 0555.

Apply http://boxen.math.washington.edu/home/jdemeyer/spkg/python-2.6.4.p12.spkg

Component: packages: standard

Keywords: python spkg

Author: Jeroen Demeyer

Reviewer: François Bissey

Merged: sage-4.8.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/12096

[jdemeyer]

Changed keywords from none to python spkg

[jdemeyer]

Author: Jeroen Demeyer

[dimpase]

comment:8

I'd like to add a comment that writable permission 0755, instead of 0555, is important for Cygwin port, as it would permit (semi)automatic rebasing of Sage dlls without the need to fiddle with permissions.

[kiwifb]

comment:9

Darn I'll have to redo my python-2.7.2 spkg against this one. What is the purpose of the braces around the dpkg stuff?

[jdemeyer]

comment:10

Replying to @kiwifb:

Darn I'll have to redo my python-2.7.2 spkg against this one.

Yeah, sorry for that...

What is the purpose of the braces around the dpkg stuff?

To make the redirection work properly. The following are equivalent:

A >/dev/null && B >/dev/null

{ A && B; } >/dev/null

But are not equivalent to

A && B >/dev/null

[kiwifb]

Reviewer: François Bissey

[kiwifb]

comment:11

I am looking at the spkg right now. It compiles fine and the patch look good. I have only one minor request about SPKG.txt before setting this to positive review.
From the current SPKG.txt:

=== Patches ===

 * cPickle.c.patch, pickle.py.patch: These add support for pickling
   classes with a metaclass via copy_reg. These have been submitted
   upstream: http://bugs.python.org/issue7689
 * locale.py: Work around import failures for locales
 * readline-spacebug.patch: Fix issue where a space is inserted
   after tab completing at the command line. This is merged upstream
   and can be removed as soon as a Python newer than 2.6.4 is used.
 * readline-Itanium-fix.patch: Fix Itanium specific readline
   extension problem.
 * sdist.py.patch: Make sure that sdist copies over the .hg directory.
 * socket.py.patch: Work around an SSL issue.
 * Makefile.pre.in.patch:  Fixes http://bugs.python.org/issue1628484
   This was merged upstream for Python 2.6.6 and 2.7.
 * socketmodule.c Makes sure some things are defined before trying to compile
   them. This was to work around a failure of _socket to build on OpenSolaris.
   see  http://bugs.python.org/issue8852 and Sage trac #9041 and #9022
 * setup.py.multiarch.patch: Library search dir is expanded on Debian
   and derivatives with multiarch (see #11243, #11447).
   This requires 'dpkg-architecture' to be installed on the affected systems.
   (Since the patch origins from Python 2.7, it can certainly be removed
   when we upgrade to that. But the patch then won't apply anymore anyway.)

The section about Makefile.pre.in should mention your bit about installing things 0755.

[jdemeyer]

Diff for the new Python spkg, for review only

[jdemeyer]

comment:12

Attachment: python-2.6.4.p11-p12.diff.gz

Replying to @kiwifb:

The section about Makefile.pre.in should mention your bit about installing things 0755.

Done. I know I haven't commited the changes, but will do that after positive_review.

[kiwifb]

comment:13

Good enough for me. It's all go.

[jdemeyer]

Merged: sage-4.8.alpha4