Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"no-drop" breaks the component #845

Closed
udimitri opened this issue Apr 21, 2019 · 0 comments · Fixed by #860
Closed

"no-drop" breaks the component #845

udimitri opened this issue Apr 21, 2019 · 0 comments · Fixed by #860
Assignees
@sagalbot
Labels
bug

Comments

@udimitri
Copy link

udimitri commented Apr 21, 2019 •
edited
Loading

Describe the bug
Adding "no-drop" breaks the component (Cannot read property '$el' of undefined).

To Reproduce
Steps to reproduce the behavior:

  1. Go to Sandbox
  2. Click no-drop
  3. You cannot bring focus to any of the dropdowns.

Expected behavior
Focus should occur, with no dropdown.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 73.0.3683.103

I believe a quick fix would be adding an if(!noDrop) wrap around toggleDropdown().
This was referenced Apr 21, 2019
Closed
Closed
@sagalbot sagalbot mentioned this issue Apr 28, 2019
Merged
@sagalbot sagalbot added the bug label Apr 28, 2019
@sagalbot sagalbot self-assigned this Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagalbot sagalbot

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@sagalbot @udimitri