Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space key no longer working in search input after 3.20.1 #1735

Closed
sagalbot opened this issue Dec 17, 2022 · 0 comments · Fixed by #1736
Closed

Space key no longer working in search input after 3.20.1 #1735

sagalbot opened this issue Dec 17, 2022 · 0 comments · Fixed by #1736

Comments

@sagalbot
Copy link
Owner

sagalbot commented Dec 17, 2022 •
edited
Loading

#1727 added 32 to selectOnKeyCodes. This prevents spaces being added to a search query.

    I think space must not default. Consider if we want to search an option that contain space.

Originally posted by @hindarwan in #1727 (comment)
@sagalbot sagalbot linked a pull request Dec 17, 2022 that will close this issue
fix(1735): use keypress event for space #1736
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(1735): use keypress event for space sagalbot/vue-select
1 participant
@sagalbot