Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type checking in test files #573

Merged
merged 2 commits into from
May 30, 2023
Merged

Fix type checking in test files #573

merged 2 commits into from
May 30, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented May 25, 2023

This PR:

  • Fixes the type checking in test files by including the test directory in the list of typescript's watched directories
  • As a side effect, it included the test directory in the final build. It was fixed by using a separate config for the production build that extends the main one but excludes the test directory from the production build. The solution was taken from here
  • I had to fix types in one place where the Contract interface was used from a different package (ethers/contracts) instead of ethers directly. I also ran npx yarn-deduplicate to remove duplicated packages.

@mmv08 mmv08 requested review from a team, rmeissner, Uxio0 and akshay-ap and removed request for a team May 25, 2023 13:27
@github-actions
Copy link

github-actions bot commented May 25, 2023

Pull Request Test Coverage Report for Build 5080528329

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.071%

Totals Coverage Status
Change from base Build 4991446336: 0.0%
Covered Lines: 308
Relevant Lines: 316

💛 - Coveralls

@mmv08 mmv08 merged commit f77dfce into main May 30, 2023
@mmv08 mmv08 deleted the fix/typescript-setup branch May 30, 2023 09:54
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants