Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Revert Messages In 1.5.0 Migration Contract #782

Closed
nlordell opened this issue Jul 3, 2024 · 2 comments
Closed

Incorrect Revert Messages In 1.5.0 Migration Contract #782

nlordell opened this issue Jul 3, 2024 · 2 comments

Comments

@nlordell
Copy link
Collaborator

nlordell commented Jul 3, 2024 •
edited
Loading

Description

The Safe 1.5.0 migration contract currently has incorrect revert messages, referencing the wrong version of the contracts:

safe-smart-account/contracts/libraries/Safe150Migration.sol

Lines 39 to 41 in 8f80a83

require(isContract(SAFE_150_SINGLETON), "Safe 1.4.1 Singleton is not deployed");
require(isContract(SAFE_150_SINGLETON_L2), "Safe 1.4.1 Singleton (L2) is not deployed");
require(isContract(SAFE_150_FALLBACK_HANDLER), "Safe 1.4.1 Fallback Handler is not deployed");

@nlordell
Copy link
Collaborator Author

nlordell commented Jul 5, 2024

May not be needed with #787

@nlordell nlordell added onhold Blocked by external dependency and removed onhold Blocked by external dependency labels Jul 5, 2024
@nlordell
Copy link
Collaborator Author

No longer needed as we have a single migration contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nlordell