Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support universal links for transactions, assets, tx details routes #24

Open
tschubotz opened this issue Jul 21, 2021 · 0 comments
Open
Assignees
Labels

Comments

@tschubotz
Copy link
Member

tschubotz commented Jul 21, 2021

Problem Owner

@MouazAlzahabi @DmitryBespalov

Part 1: Define the problem

What problem are you trying to solve?

If a Web user shares a link with a Mobile user, it will not be the expected destination. It brings inconveniences like no easy way to link or share a transaction.

What links we should understand and open on Mobile when shared on the Web:

  • Assets balances
  • Assets collectibles
  • Transactions queue
  • Transactions history
  • Transaction details

What links we should allow sharing on Mobile:

  • Transaction details

What is your hypothesis?

Adding support for most common web links will make communication between Safe users much more straightforward.

What value does this bring to our customers and/or our mission? What is the goal?

  • Solving this problem would simplify communications between our users

How do we measure it?

  • Number of times universal links were handled by the app (track different types of links)
  • Number of times the tx details link was shared from the mobile app

Links:

Requirements: https://docs.google.com/document/d/1aoW-HZDeQCRpMVMaHOUZQZyBNMWcqCo51IEkq3zEBlE/edit

Part 2: Shaping the problem

Non Goal(s)

  • Supporting other links not mentioned in the description
  • Temporary add or view the safe, not only transaction details that are linked.

Possible Solution(s)

  • In the transaction details screen, add a Share button that would generate a link and opens the system 'share' pop-up
  • Handle opening transaction details links on mobile
  • Support the current version of the link schema that exists on the web (uses safeTxHash) - references only queued or outgoing transactions

Rough Scoping & Timeline

Effort: S - less than a week

  • Handle universal links on mobile
  • Allow sharing tx details link from mobile

Risk(s), Key Trade Offs & Decisions

No

Concept Mocks

Screenshot 2022-01-28 at 13 22 11

Open Questions

  • Allow referencing to incoming transactions in history
  • Allow referencing safe creation transaction in the transaction history
@tschubotz tschubotz changed the title Inconvienient to refer or link to a specific transaction Inconvinient to refer or link to a specific transaction Jul 22, 2021
@tschubotz tschubotz changed the title Inconvinient to refer or link to a specific transaction Inconvenient to refer or link to a specific transaction Jul 22, 2021
@sche sche transferred this issue from 5afe/safe Jan 7, 2022
@sche sche added the mobile label Jan 7, 2022
@sche sche changed the title Inconvenient to refer or link to a specific transaction Support universal links for all possible Web screen routes Mar 9, 2022
@sche sche changed the title Support universal links for all possible Web screen routes Support universal links for most used Web screen routes Mar 10, 2022
@sche sche changed the title Support universal links for most used Web screen routes Support universal links for transactions, assets, tx details routes May 2, 2022
@sche sche added mobile and removed mobile labels May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants