diff --git a/modules/allowances/CHANGELOG.md b/modules/allowances/CHANGELOG.md new file mode 100644 index 000000000..455ff9df8 --- /dev/null +++ b/modules/allowances/CHANGELOG.md @@ -0,0 +1,31 @@ +# Changelog + +This changelog only contains changes starting from version 0.1.1 + +# Version 0.1.1 + +## Compiler settings + +Solidity compiler: [0.7.6](https://github.com/ethereum/solidity/releases/tag/v0.7.6) + +Solidity optimizer: disabled + +## Expected addresses + +- `AllowanceModule` at `0xAA46724893dedD72658219405185Fb0Fc91e091C` + +## Changes + +### General + +#### Fix the EIP-712 transfer typehash + +Issue: [#70](https://github.com/safe-global/safe-modules/issues/70) + +The typehash for the transfer was incorrect, making it impossible to use the module with EIP-712 signatures. + +#### Add a check for `resetTimeMin` + +For recurring allowances, the `resetTimeMin` must be greater than 0. However, the check was missing, making it possible to specify a `resetTimeMin` of 0, resulting in a divide by zero error and the transaction consuming all gas. + +The change was suggested by the [Ackee blockchain](https://ackee.xyz/) during the audit of the module. \ No newline at end of file diff --git a/modules/allowances/contracts/AllowanceModule.sol b/modules/allowances/contracts/AllowanceModule.sol index 92564d9f8..5e1d35f4b 100644 --- a/modules/allowances/contracts/AllowanceModule.sol +++ b/modules/allowances/contracts/AllowanceModule.sol @@ -20,7 +20,7 @@ interface ISafe { contract AllowanceModule is SignatureDecoder { string public constant NAME = "Allowance Module"; - string public constant VERSION = "0.1.0"; + string public constant VERSION = "0.1.1"; bytes32 public constant DOMAIN_SEPARATOR_TYPEHASH = 0x47e79534a245952e8b16893a336b85a3d9ea9fa8c573f3d803afb92a79469218; // keccak256( diff --git a/modules/allowances/docs/ackee-blockchain-safe-allowance-module-report.pdf b/modules/allowances/docs/ackee-blockchain-safe-allowance-module-report.pdf new file mode 100644 index 000000000..f723a5a5c Binary files /dev/null and b/modules/allowances/docs/ackee-blockchain-safe-allowance-module-report.pdf differ diff --git a/modules/allowances/package.json b/modules/allowances/package.json index e52ec1e98..365b3d51d 100644 --- a/modules/allowances/package.json +++ b/modules/allowances/package.json @@ -1,6 +1,6 @@ { "name": "@safe-global/safe-allowance-module", - "version": "1.0.0", + "version": "0.1.1", "description": "Allowance module for the gnosis safe", "keywords": [ "Ethereum",